Introduce initAfterInsert() framework function - #14402
Open
magnesj wants to merge 1 commit into
Open
Conversation
…ively() and initAfterReadRecursively()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14401
Introduce
caf::PdmXmlObjectHandle::initAfterInsert()combining the manualresolveReferencesRecursively()+initAfterReadRecursively()pair that must be called after inserting a copied object into the document tree. The function resolves references first so thatinitAfterRead()overrides can rely on resolved pointer fields, and asserts that the object has a parent field to catch calls made before insertion (the bug class behind #14372).Migrated the 18 call sites that used the adjacent pair (16 files). Note that
RicDeleteItemExec::undo()previously called the two functions in reversed order (init before resolve); it now uses the resolve-first order like all other sites.Intentionally not migrated:
RiaApplicationproject load andRicSummaryPlotTemplateTools/RicPasteSummaryCurveFeature, which interleave other work between resolve and initcafTestApplicationdocument load, which operates on a root object with no parent fieldA unit test in
cafPdmAdvancedTemplateTest.cppverifies thatinitAfterInsert()resolves a nulled pointer field and re-runsinitAfterRead()on an inserted copy.