[18.0][IMP] web_responsive: Move AppsMenuPreferences to XML#3569
Open
tarteo wants to merge 1 commit into
Open
Conversation
Contributor
tarteo
changed the title
tarteo
force-pushed
the
18-apps-menu-preference-template-to-xml
branch
from
37b39a1 to
717dbe2
Compare
Member
Author
|
@OCA/web-maintainers This is a simple change, can I fast forward this? |
Member
|
Is this the drop icon menu? It would be good to remove it and move the preferences to the user config dialog. |
Member
Author
|
Correct! This one: |
Member
|
Then can you please do that option instead for fixing this once for all. I understand that if you want this to be inheritable, if for hiding it, so let's move it once for all into the user dropdown. |
Member
Author
|
I don't have time for that atm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it easier to change the button by inheritance