Repository navigation
Conversation
camt.054 notifications (e.g. Raiffeisen) have neither Acct/Ccy nor Bal, which raised an IndexError in _split_camt. Fall back on the currency of the entries and add a notification instead of crashing when no currency is found. Assisted-by: claude-opus-5-5, medium, claude-code
ecino
marked this pull request as ready for review
October 7, 2026 12:40
Contributor
|
@ecino |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
camt.054 notifications (e.g. from Raiffeisen) contain neither
Acct/CcynorBal, so the currency lookup in_split_camtreturns an empty list and the import crashes:This change:
Ntry/Amt/@Ccy) when neither the account currency nor a balance is present. XPath returns nodes in document order, soAcct/CcyandBalstill take precedence for camt.053;