Repository navigation
Conversation
- values-zh-rCN overlay: 879 strings + 7 plurals, English stays the default - drop translatable="false" on the 618 user-facing strings that are now translated; text of existing entries is untouched - localize the duration-unit dropdown labels (the stored values remain the seconds/minutes/hours/days logic keys the converters match on)
Llhhy1
added a commit
to Llhhy1/OlliteRT
that referenced
this pull request
Sep 24, 2026
Llhhy1
added a commit
to Llhhy1/OlliteRT
that referenced
this pull request
Sep 24, 2026
Author
|
Friendly nudge — no rush at all, I know this is a solo side project. Two things I can do to make review easier whenever you get to it:
Also FYI: CI hasn't run yet, presumably because workflow runs need approval for a first-time contributor's fork PR. And I'm happy to rebase if Whatever you prefer — including "not right now". Thanks for the app either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds Simplified Chinese (
values-zh-rCN) translations.values-zh-rCN/strings.xml— 879 strings + 7 plurals as a pure overlay. English remains the default locale, so no behavior change for existing users. Android 13+ gets a per-app language entry automatically from the resource table; Android 12 follows the system locale. No Kotlin UI code or manifest changes were needed.values/strings.xml— removedtranslatable="false"from the 618 user-facing strings that are now translated, and added fourunit_*labels. No existing text was modified: the diff on existing lines is attribute removals only. Those strings are rendered in the Settings cards, dialogs and log rows, so the flag looked like leftover from the original sample project; keeping it produces 618Untranslatablewarnings once a locale folder exists, and it keeps the strings invisible to translation tooling.SettingRenderers.kt(6 lines) — the duration dropdowns used their stored logic key as the visible label, so 检查频率 rendereddaysin every language. Labels now come fromunit_seconds/minutes/hours/days; the persisted value and thetoBaseUnit/fromBaseUnitconverters are untouched, so existing preferences keep working.values-zh-rCNwithapp_labelsoMissingTranslationstays clean for the dev/beta/stable source sets.%1$dms,t/s), sampler parameter names (temperature,top_p,top_k,max_tokens, which mirror the API fields), and input placeholders (hf_…,8000, IP/CIDR examples).String names, format placeholders and
\n/\u0020escapes are asserted identical tovalues/strings.xmlby script, so nothing drifts and the concatenated log fragments (logs_event_*) keep their surrounding spaces.Verification
./gradlew :app:lintStableDebug→ 0 errors, 46 warnings — identical to the baseline without the locale folder.aapt2 dump resourceson the built APK → default config stillStart Server,zh-rCNconfig returns启动服务器.daysdropdown bug surfaced).Process: translations were drafted with AI assistance, then reviewed entry by entry against the running app.
Screenshots
Images are hosted from a
zh-screenshotsbranch of my fork so they stay out of this diff.Type of change
Additional information
translatable="false"removal or the unit-dropdown fix into separate PRs if that reviews better.Checklist
./gradlew :app:compileStableDebugKotlin)./gradlew lint