sync be with sdk updates#145
Merged
Merged
Conversation
volodymyr-narada
commented
Jun 8, 2026
xTRam1
approved these changes
Jun 8, 2026
xTRam1
left a comment
xTRam1
left a comment
Contributor
There was a problem hiding this comment.
Approved directionally. This SDK helper/export is the right shape for letting caddie reuse the SDK initialization path, and checks are green. Please make sure the version that caddie pins is actually published/installable for Python 3.12 before merging the dependent caddie PR.
| *, | ||
| browser_window_id: str, | ||
| cloud_browser_session_id: str | None = None, | ||
| stop_cloud_browser_session_on_close: bool = True, |
Contributor
Author
There was a problem hiding this comment.
note:
stop_cloud_browser_session_on_close defaults to True to preserve normal SDK behavior: when the SDK creates/owns a cloud browser session, close() should clean it up. The caddie helper passes False because caddie created and owns that session, so the SDK should only initialize it and disconnect local CDP/Playwright without stopping it.
zizhengtai
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.