Fix Cloud Browser trace agent type formatting#110
Closed
xTRam1 wants to merge 2 commits into
Closed
Conversation
xTRam1
changed the title
Contributor
|
Probably easier to redo this PR because of the merge conflicts |
…-agent-type-fix-main # Conflicts: # packages/narada-core/pyproject.toml # packages/narada-pyodide/pyproject.toml # packages/narada-pyodide/src/narada/window.py # packages/narada-pyodide/tests/test_cloud_browser.py # packages/narada/pyproject.toml # uv.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent_typelabels for built-in Pyodidewindow.agent()trace eventsnarada-coretrace parsing tolerate historical numericagent_typevaluesWhy
Deep Cloud Browser nested APA trace runs can fail when normal
window.agent()trace events carry numeric enum values such as2, while the trace parser expects strings. The E2E harness captured this as a real product failure in the deep Cloud Browser lane.Validation
uv run pytest packages/narada-pyodide/tests/test_cloud_browser.py packages/narada/tests/test_input_variables.py -quv run ruff check packages/narada-core/src/narada_core/tracing/model.py packages/narada-pyodide/src/narada/window.py packages/narada-pyodide/tests/test_cloud_browser.pypython -m py_compile packages/narada-core/src/narada_core/tracing/model.py packages/narada-pyodide/src/narada/window.py packages/narada-pyodide/tests/test_cloud_browser.pygit diff --check