Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
|
This was referenced Oct 26, 2026
Limit the retry fix to downloading the existing asset and checking it with the unchanged inventory validator. Restore the original release flow and remove the new Go command, documentation, and CI setup. Relates to #2909 Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
Reuse a complete release/chart fixture for identity and retry tests. Keep both retained and regenerated inventories valid for the existing consumer. Relates to #2909 Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Backport #2910 to the compute-plane 1.0 maintenance train. A release retry now validates the retained inventory before accepting it and publishing the release.
Additional Details
Downloads the existing asset to a temporary file and applies the existing Python validator with the expected version, tag, and commit.
Keeps valid existing assets unchanged. Validation or download failures stop release publication.
Applies to future tags containing this commit. Can merge independently of fix(release): verify retained stack inventories on retry #2910.
Retries still require rendering to succeed. Validation uses the existing Python checks; the Go consumer remains responsible for full inventory validation.
For the Reviewer
The net change is limited to
tools/ci/github-releaseand its Python tests.For QA
Passed all 99 release-helper Python tests and whitespace checks. Tests use offline fixtures; both success fixtures also passed the existing Go consumer parser in a local overlay check. Runtime QA is not needed. No dependency, license, NOTICE, or documentation changes.
Issues
Relates to #2909. Keep open until main and both maintenance backports merge.
Checklist