Skip to content

fix(release): verify retained stack inventories [compute-plane 1.0] - #2912

Open
sbaum1994 wants to merge 3 commits into
release-deploy/stacks/nvcf-compute-plane/v1.0from
sbaum1994/inventory-retry-compute-plane-1-0
Open

sbaum1994 wants to merge 3 commits into
release-deploy/stacks/nvcf-compute-plane/v1.0from
sbaum1994/inventory-retry-compute-plane-1-0

Conversation

@sbaum1994

@sbaum1994 sbaum1994 commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

TL;DR

Backport #2910 to the compute-plane 1.0 maintenance train. A release retry now validates the retained inventory before accepting it and publishing the release.

Additional Details

  • Downloads the existing asset to a temporary file and applies the existing Python validator with the expected version, tag, and commit.

  • Keeps valid existing assets unchanged. Validation or download failures stop release publication.

  • Applies to future tags containing this commit. Can merge independently of fix(release): verify retained stack inventories on retry #2910.

  • Retries still require rendering to succeed. Validation uses the existing Python checks; the Go consumer remains responsible for full inventory validation.

For the Reviewer

The net change is limited to tools/ci/github-release and its Python tests.

For QA

Passed all 99 release-helper Python tests and whitespace checks. Tests use offline fixtures; both success fixtures also passed the existing Go consumer parser in a local overlay check. Runtime QA is not needed. No dependency, license, NOTICE, or documentation changes.

Issues

Relates to #2909. Keep open until main and both maintenance backports merge.

Checklist

  • Contributing Guidelines reviewed.
  • Commits signed off for DCO.
  • Regression tests cover the change.
  • Existing documentation remains current.

Backport #2910 to the compute-plane 1.0 branch using its existing inventory
consumer parser. Validate the retained original before publication and
provide the declared Go toolchain for release-helper regression tests.

Relates to #2909

Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
@sbaum1994
sbaum1994 requested a review from a team as a code owner October 26, 2026 15:04
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 1
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Limit the retry fix to downloading the existing asset and checking it with
the unchanged inventory validator. Restore the original release flow and
remove the new Go command, documentation, and CI setup.

Relates to #2909

Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
Reuse a complete release/chart fixture for identity and retry tests. Keep both retained and regenerated inventories valid for the existing consumer.

Relates to #2909

Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant