Repository navigation
Conversation
Pin BYOO and ordinary NVCF collectors to 0.160.0-nv-0.2.8 through the existing chart 1.28.0 image overrides. Reuse main BYOO routing and collector inventory discovery without upgrading NVCA 3.10.3 or changing other worker images. Both NVIDIA collector image dependencies move to 0.160.0-nv-0.2.8. No third-party package or license changes; NOTICE is unchanged. Relates to #2823 Relates to #2432 Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
|
4 tasks done
Relates to #2823 Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
The Helm job used a depth-one checkout with no tags, so the collector regression could not archive the stack-pinned chart. Fetch full history and tags in that existing job. Relates to #2823 Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
This was referenced Oct 24, 2026
Skip incomplete collector image pairs only when explicitly disabled. Preserve required image precedence and cover collector discovery through the publisher collection path. Relates to #2823 Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
sbaum1994
marked this pull request as ready for review
October 24, 2026 22:13
sbaum1994
merged commit Oct 24, 2026
d5bac2a
into
release-deploy/stacks/nvcf-compute-plane/v1.0
17 checks passed
Contributor
|
This PR is included in version 1.0.2. The release is available on GitHub release. |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Select BYOO and ordinary NVCF collector
0.160.0-nv-0.2.8in the compute-plane 1.0 maintenance stack. The existing stack still selected ordinary0.157.0-nv-0.2.1and inherited BYOO0.160.0-nv-0.2.5from the operator chart, leaving the reviewed security fixes out of this delivery.Additional Details
Backport the BYOO stack image routing from #2680 and #2751, and the collector inventory discovery from #2869. Both functions and tasks receive the BYOO override. The operator and self-managed backend receive the ordinary collector pin. The repository follows
global.image, with per-image override support, so the public release configuration resolves both images undernvcr.io/nvidia/nvcf.The pinned operator chart remains
1.28.0; NVCA and its operator remain3.10.3. The helm-managed backend is empty for this self-managed stack. The ordinary collector remains disabled by default and optional in the inventory. Inventory discovery tolerates a partial image pair only when explicitly disabled, preserves required BYOO entries, and tests the publisher collection path. Main retains its newer wrapper 0.4 collector train.For the Reviewer
Draft and dependent on #2869. Runtime routing antecedents #2680 and #2751 and producer security backport #2865 have merged. No NICLLS, Samba, source collector, registry, release tag, or umbrella version changes are included. The existing chart-validation CI command fetches release history and tags and also runs the collector regression; no new job is added.
Merge this after the main inventory fix, then publish a new compute-plane 1.0 patch with its inventory. The next version after the existing
deploy/stacks/nvcf-compute-plane/v1.0.1tag is1.0.2, subject to other releases landing first. The umbrella delivery must consume that independently published stack. Update public catalog version facts only after the new inventory exists; the ordinary collector image needs an identity distinct from the existing chart with the same name during that sync.Dependencies: the two NVIDIA collector images move to
0.160.0-nv-0.2.8; no new third-party packages or license changes. NOTICE is unchanged. Runtime topology and diagrams are unchanged.For QA
Passed on this branch:
test-collector-images,test-observability-profile, andtest-nvca-default-ownership.deploy/helm/nvca-operator/v1.28.0chart with local stack values and compared the complete operator output to refreshed golden fixtures. Only the ordinary pin and BYOO function/task overrides changed.nvca-entrypoints.sh,compare-golden.sh, and ShellCheck.go test -C tools/docs-version-sync ./...andgo vet -C tools/docs-version-sync ./....git diff --check.The review follow-up reran the full Go suite, Go vet, and the exact CI command
make -C deploy/stacks/nvcf-compute-plane test-nvca-default-ownership test-collector-imageson this branch. New regression coverage checks disabled partial images, required BYOO precedence in either traversal order, and publisher collection.At
2c079a0b2, the final-head Go tools job and Helm charts job passed.These are rendering and inventory checks, not live deployment qualification. Live BYOO task/function telemetry export, ordinary collector configuration validation against the published image, and customer digest readback remain outstanding. Publication verification succeeded upstream, but the local image credentials currently return access denied. Keep this PR draft until the main dependency and required qualification are complete. No clusters or releases were changed.
Issues
Relates to #2823
Relates to #2432
Checklist