Repository navigation
fix(nvca): set up RBAC before writing the agent config ConfigMap - #2344
Merged
apartha-nv merged 1 commit intoOct 7, 2026
Conversation
setupNVCAAgentInfra wrote the agent config ConfigMap before setting up RBAC. newAgentConfigChangedCheck detects pending rollouts by diffing the desired config against the live ConfigMap in the cluster, not against NVCFBackend.Status. When a Helm update added the first allowedExtraKubernetesTypes entry, the operator's own RBAC grant for the new type was not yet usable, so the ClusterRole update failed with Forbidden. By that point the ConfigMap had already been written to the desired state, so every later periodic sync saw "no change" and never retried RBAC or the Deployment rollout, leaving the agent stuck on the old configuration until an unrelated change happened to trip a different rollout check. Move setupNVCARBAC ahead of setupAgentConfigConfigMap so a transient RBAC failure leaves the ConfigMap unwritten, keeping the change detectable and the rollout retryable on the next periodic sync. (cherry picked from commit 4187ce0)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
shobham-nv
approved these changes
Oct 7, 2026
apartha-nv
merged commit Oct 7, 2026
bf90b50
into
release-src/compute-plane-services/nvca/v3.7
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cherry-pick of #2283 to the v3.7 release line.
What changed
Cherry-pick of 4187ce0 from main.
Testing
References
Cherry-pick of #2283
Related Pull Requests
#2283