Use cuda::stream_ref across remaining libcudf APIs - #23691
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
libcudf
fa33c11 to
834a687
Compare
vyasr
changed the title
834a687 to
ee2961a
Compare
| cudf::table_view const& table) | ||
| { | ||
| auto stream = rmm::cuda_stream_default; | ||
| auto stream = cuda::stream_ref{}; |
There was a problem hiding this comment.
I think the default constructors like this are deprecated. Please check that. I see this in a few examples.
| [[nodiscard]] bool may_evaluate_null(table_view const& left, | ||
| table_view const& right, | ||
| rmm::cuda_stream_view stream) const override; | ||
| cuda::stream_ref stream) const override; |
There was a problem hiding this comment.
This file appears to be missing <cuda/stream> includes. Same for cpp/src/ast/jit/expressions.cpp and others in cpp/src/ast. Can you check everything for IWYU?
| _null_handling{null_handling}, | ||
| _mr{std::move(mr)}, | ||
| _d_agg_kinds{0, rmm::cuda_stream_default, cudf::get_current_device_resource_ref()}, | ||
| _d_agg_kinds{0, cuda::stream_ref{}, cudf::get_current_device_resource_ref()}, |
There was a problem hiding this comment.
I think the nullary constructor is deprecated.
| #else | ||
| rmm::cuda_stream_view const default_stream_value{}; | ||
| cuda::stream_ref const default_stream_value{}; |
There was a problem hiding this comment.
This should be explicit and not default-constructed. But should it be set to cudaStreamLegacy or cudaStreamDefault? Probably Legacy?
| cuda::stream_ref const default_stream_value{}; | |
| cuda::stream_ref const default_stream_value{cuda::stream_ref{cudaStreamLegacy}}; |
| #include <rmm/device_uvector.hpp> | ||
| #include <rmm/exec_policy.hpp> | ||
|
|
||
| #include <cuda/stream_ref> |
There was a problem hiding this comment.
There are a few files like this with header changes but no changes in the code itself. I don't think the header is used. Can we audit for those files and remove the headers if they're not required?
ee2961a to
d6cfbf8
Compare
vyasr
changed the title
d6cfbf8 to
dd55488
Compare
2 participants
Description
This fifth batch migrates the remaining core libcudf headers and implementations from
rmm::cuda_stream_viewtocuda::stream_ref.It includes the final central stream utility API updates, such as the default stream and stream pool helpers, while keeping
rmm::cuda_streamownership unchanged. Tests, benchmarks, examples, and docs are split into follow-up draft PRs.Contributes to #23636
Checklist