[CUB] Refactor DeviceAdjacentDifference::SubtractRight to always take an environment#9419
Open
miscco wants to merge 1 commit into
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
miscco
force-pushed
the
device_adjacent_difference_subtract_right_env
branch
from
18e8403 to
8cfab18
Compare
miscco
force-pushed
the
device_adjacent_difference_subtract_left_env
branch
from
ba420ef to
3c91b42
Compare
miscco
force-pushed
the
device_adjacent_difference_subtract_right_env
branch
from
8cfab18 to
c000627
Compare
Contributor
Jacobfaib
reviewed
Jun 12, 2026
|
|
||
| c2h::host_vector<type> h_in = in; | ||
| c2h::host_vector<type> reference(num_items); | ||
| std::adjacent_difference(h_in.begin(), h_in.end(), reference.begin(), ref_diff<type>{}); |
Comment on lines
+112
to
+114
| auto error = cub::DeviceAdjacentDifference::SubtractRight( | ||
| static_cast<void*>(nullptr), expected_allocation_size, in.begin(), num_items, cuda::std::minus<>{}); | ||
| REQUIRE(error == cudaSuccess); |
Comment on lines
+115
to
+116
| REQUIRE(cudaSuccess == cudaPeekAtLastError()); | ||
| REQUIRE(cudaSuccess == cudaDeviceSynchronize()); |
miscco
force-pushed
the
device_adjacent_difference_subtract_right_env
branch
from
c000627 to
9ade375
Compare
miscco
force-pushed
the
device_adjacent_difference_subtract_left_env
branch
2 times, most recently
from
3c91b42 to
9004022
Compare
miscco
force-pushed
the
device_adjacent_difference_subtract_right_env
branch
from
9ade375 to
0dcfcac
Compare
This comment has been minimized.
This comment has been minimized.
…ke an environment We want to be able to pass tunings to the APIs that take user provided memory.
miscco
force-pushed
the
device_adjacent_difference_subtract_right_env
branch
from
0dcfcac to
657a73c
Compare
miscco
force-pushed
the
device_adjacent_difference_subtract_left_env
branch
from
9004022 to
30ac019
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 54m: Pass: 100%/287 | Total: 11d 21h | Max: 2h 53m | Hits: 19%/1355601See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes
Checklist