Fix ModuleNotFoundError for jupyter-dark-detect on Google Colab. - #254
Open
EricHayter wants to merge 1 commit into
Open
Fix ModuleNotFoundError for jupyter-dark-detect on Google Colab.#254EricHayter wants to merge 1 commit into
EricHayter wants to merge 1 commit into
Conversation
PR NVIDIA#153 added `jupyter-dark-detect` to the tutorial `requirements.txt` files, which provision the Brev containers. The Colab bootstrap cells are a separate path that never reads those files, so `import Sources.ach` fails on Colab. The import is at module scope, so this breaks every cell that renders a plot or animation, not just the theming. First observed in 01.04.02, opened from the Colab badge in tutorials/cuda-cpp/README.md. Install the package in the eight Colab bootstrap cells that fetch `ach.py`, and make the import non-fatal in all ten copies of `ach.py`. `is_dark()` already returns False when detection fails, so assuming a light theme when the package is absent matches its existing behavior. Signed-off-by: Eric <hayter.eric@gmail.com>
Contributor
|
👋 Thank you for your contribution! This pull request is from a forked repository so GitHub Actions will not be able to run CI. A maintainer will review your changes shortly and manually trigger the CI. @maintainers Please review this PR when you have a chance and follow the instructions in the CONTRIBUTING.md file to trigger the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #153 added
jupyter-dark-detectto the tutorialrequirements.txtfiles, which provision the Brev containers. The Colab bootstrap cells are a separate path that never reads those files, soimport Sources.achfails on Colab. The import is at module scope, so this breaks every cell that renders a plot or animation, not just the theming. First observed in 01.04.02, opened from the Colab badge in tutorials/cuda-cpp/README.md.Install the package in the eight Colab bootstrap cells that fetch
ach.py, and make the import non-fatal in all ten copies ofach.py.is_dark()already returns False when detection fails, so assuming a light theme when the package is absent matches its existing behavior.