Skip to content

fix(ledger): exclude scope boundaries from analyzer work - #802

Open
efegokdemir wants to merge 1 commit into
NVIDIA:mainfrom
efegokdemir:codex/skill-800-scope-exclusion-accounting
Open

efegokdemir wants to merge 1 commit into
NVIDIA:mainfrom
efegokdemir:codex/skill-800-scope-exclusion-accounting

Conversation

@efegokdemir

Copy link
Copy Markdown
Contributor

What

Why

Binary members that are intentionally out of scope were included in each analyzer's planned work. Finalization then counted the unrecognized out_of_scope outcome as failed work even though the analyzer status was completed, producing an inconsistent report that SkillEvaluator rejects.

How

analyzer_status_for_events now excludes scope_boundary records from the analyzer work plan. If an analyzer has only scope boundaries, its status is not_applicable; the exclusions are still reported separately.

Testing

  • The new finalization regression failed before the fix: it counted 2 planned items instead of 1 and treated the scope boundary as failed.
  • After the fix, the regression and ledger tests pass.
  • make test-unit: 10,539 passed, 14 skipped, 133 deselected, 4 xfailed.
  • make lint, make format-check, and python -m build --no-isolation passed.
  • Mypy on the changed module reports an existing call-overload error at inspection_ledger.py:1081; the same error is present on the base commit. The changed module passes when that existing diagnostic is suppressed and imports are silenced.

AI assistance

ChatGPT assisted with the implementation and regression tests. The commit is DCO signed off.

Signed-off-by: Efe <efe@rexcode.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

analyzer_statuses reports completed while counting out-of-scope binary members as failed, so SkillEvaluator rejects the report

1 participant