Repository navigation
fix(ledger): exclude scope boundaries from analyzer work - #802
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe <efe@rexcode.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scope_exclusions.analyzer_statusesreportscompletedwhile counting out-of-scope binary members asfailed, so SkillEvaluator rejects the report #800.Why
Binary members that are intentionally out of scope were included in each analyzer's planned work. Finalization then counted the unrecognized
out_of_scopeoutcome as failed work even though the analyzer status wascompleted, producing an inconsistent report that SkillEvaluator rejects.How
analyzer_status_for_eventsnow excludesscope_boundaryrecords from the analyzer work plan. If an analyzer has only scope boundaries, its status isnot_applicable; the exclusions are still reported separately.Testing
make test-unit: 10,539 passed, 14 skipped, 133 deselected, 4 xfailed.make lint,make format-check, andpython -m build --no-isolationpassed.call-overloaderror atinspection_ledger.py:1081; the same error is present on the base commit. The changed module passes when that existing diagnostic is suppressed and imports are silenced.AI assistance
ChatGPT assisted with the implementation and regression tests. The commit is DCO signed off.