Repository navigation
fix(pi): require confirmation for external scan inputs - #791
Open
yashrajp22 wants to merge 3 commits into
Open
yashrajp22 wants to merge 3 commits into
yashrajp22 wants to merge 3 commits into
Conversation
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pi scan tool could read an external target or YARA rules directory without asking the user. It now shows the complete external read scope and remote target in a confirmation dialog before starting the CLI. Noninteractive sessions reject these requests, local workspace scans stay prompt-free, and canonical paths are checked again after the dialog.
Validation: 88 Pi/OpenCode tests passed in an offline Linux container. The new denied-access regression fails against the original implementation. Synthetic fixtures cover external files, rule directories, symlinks, remote targets, cancellation, and input changes during approval. CLI execution is mocked in these extension tests; no live provider was contacted.