Skip to content

fix(images): retain compiled dependency sources and notices - #14761

Merged
cv merged 3 commits into
v1from
fix/13524-compiled-dependency-sources
Nov 22, 2026
Merged

cv merged 3 commits into
v1from
fix/13524-compiled-dependency-sources

Conversation

@prekshivyas

@prekshivyas prekshivyas commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Retain compiled dependency sources and original notices in Fabric runtime images, and make retained source directories accessible to sandbox users. Build Tiktoken 0.13.0 from its unmodified source distribution with a retained Cargo lock so its compiled dependencies are known.

Problem

The retained Codex project source does not include its locked Cargo dependency closure. Python wheels identify additional compiled Rust and OpenSSL dependencies whose sources are absent. Several source directories also lack traversal permission for sandbox users.

Part of #13524. This change does not resolve the remaining rights decisions or establish complete per-binary license clearance.

Change

  • Retain all 1,331 external Codex Cargo dependencies, vendor configuration, and a workspace-normalized lock without changing external pins or shipped binaries.
  • Retain checksum-verified Cargo/OpenSSL originals from installed wheel SBOMs, Python source distributions and their Cargo-lock dependencies. Include the locked Nemo Relay CLI and ripgrep sources missed by the wheel-only scan.
  • Build Tiktoken from its unmodified 0.13.0 sdist with a frozen 27-package Cargo dependency set. Install only that wheel in Deep Agents and mini-swe-agent, pin its hash in the retained requirements, and retain its vendor sources and lock.
  • Retain 28 original upstream notice files from crate-recorded revisions; add matching notices to native wheel dependency bundles.
  • Preserve readable files and traversable source directories. Document extraction, offline source resolution, and remaining provenance limits.
  • Install Python 3.14 in Unix unit-test jobs for the source-retention tests' standard-library TOML parser.

Beyond CI

Built Codex, Deep Agents, mini-swe-agent, and Hermes AMD64 images on Linux. Verified installed wheel source hashes and archive readability as the sandbox user, with a read-only root and networking disabled. Verified all 1,331 Codex external lock records remained unchanged, both Linux architectures resolve offline with an empty Cargo cache, and the documented Bubblewrap release build succeeds using Rust 1.95 with networking disabled.

The actual Codex dependency archive adds 293 MB compressed. No source archive or audit inventory is committed.

ARM64 image builds and the complete live-Docker suite remain unverified. The suite launcher rejects this macOS host; the Linux qualification host has Docker but no host Rust toolchain. The retained Tiktoken lock describes the image's new source build; it does not reconstruct historical upstream wheels. The retained source sets are conservative closures, not linker-level proof of every binary's contents.

Tiktoken qualification on native AMD64 and ARM64 compared the rebuilt and published wheels across four encodings, each with 1,011 texts covering Unicode, special tokens, batching, and round trips. Results matched on both architectures with network disabled for the rebuilt-wheel run. All vendored file checksums matched the 27-package lock. Both affected AMD64 runtime images contain the exact rebuilt extension and retain its wheel hash, lock, and matching sources.

A post-fix AMD64 scan of ELF files under /opt/fabric found no unmatched versioned Rust source paths: 1,420 per-binary crate references across 32 binary instances in the four qualified images were covered by retained sources. This checks embedded references, not stripped code or complete non-Cargo linkage.

@github-actions github-actions Bot added the v1 NemoClaw v1 branch label Nov 21, 2026
@prekshivyas

Copy link
Copy Markdown
Collaborator Author
Authoring session — opening
Field Status Value Evidence or limit
Harness recorded Codex Desktop, CLI 0.163.0-alpha.11.1 Persisted session metadata; repository working-directory and authoring commands match this change.
Skills recorded test-driven-development; write-tests; nemoclaw-contributor-create-pr; nvidia-style-guide; brev-cli; managing-glean Full skill bodies found in the authoring record, including earlier work in this same session.
Instruction files partial Global GitHub workflow; repository AGENTS.md; WRITING.md; PULL_REQUEST_TEMPLATE.md; SESSION_REPORT_TEMPLATE.md Full injected workflow and complete file bodies inspected. Other startup guidance is not exhaustively identifiable as individual files.
Tool calls partial exec: 1147; request_user_input_async: 6; sleep: 31; wait: 6 Attempted wrapper invocations, including failures, counted from persisted function/custom calls. Nested tools are visible as script source but not separately counted runtime telemetry; their invocation totals are unavailable.
Tokens partial input: 219581858; cached input: 217177984; output: 825002 Last usable cumulative event token counters before cutoff. These cover the whole session, including earlier roadmap work and merged PRs. Separate response/compaction accounting has not been reconciled, so these are a known lower bound.
Session window recorded 2026-11-20T16:43:30.572Z to 2026-11-21T23:31:45.830Z; 1 day, 6:48:15 Whole persisted session to cutoff, including idle time and earlier work; not a task-only interval. No inherited fork boundary is recorded.
Compactions recorded 7 Persisted compacted events through cutoff.
Models recorded gpt-6.1-sol Model recorded in turn contexts through cutoff.
Reasoning levels recorded medium Effort recorded in turn contexts through cutoff.

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Selected hardware E2Es

Commit: caf310bb6c0489ebf8fcaa36f546c268c576163b

Selected cases run automatically; results do not gate merging.

Shared code or test infrastructure changed.

  • dgx-station-openclaw-nemotron
  • docker-openclaw-hermes-ollama
  • docker-openclaw-llama-cpp
  • docker-openclaw-vllm
  • docker-openclaw-vllm-shared

@prekshivyas
prekshivyas requested a review from cv November 22, 2026 00:26
@prekshivyas prekshivyas added this to the Roadmap: GTC DC 2026 milestone Nov 22, 2026
@cv
cv merged commit 7a17ac5 into v1 Nov 22, 2026
119 of 122 checks passed
@cv
cv deleted the fix/13524-compiled-dependency-sources branch November 22, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1 NemoClaw v1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants