Repository navigation
fix(images): retain compiled dependency sources and notices - #14761
Merged
Merged
Conversation
Collaborator
Author
Authoring session — opening
|
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14761.docs.buildwithfern.com/nemoclaw |
Contributor
Selected hardware E2EsCommit: Selected cases run automatically; results do not gate merging. Shared code or test infrastructure changed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain compiled dependency sources and original notices in Fabric runtime images, and make retained source directories accessible to sandbox users. Build Tiktoken 0.13.0 from its unmodified source distribution with a retained Cargo lock so its compiled dependencies are known.
Problem
The retained Codex project source does not include its locked Cargo dependency closure. Python wheels identify additional compiled Rust and OpenSSL dependencies whose sources are absent. Several source directories also lack traversal permission for sandbox users.
Part of #13524. This change does not resolve the remaining rights decisions or establish complete per-binary license clearance.
Change
Beyond CI
Built Codex, Deep Agents, mini-swe-agent, and Hermes AMD64 images on Linux. Verified installed wheel source hashes and archive readability as the sandbox user, with a read-only root and networking disabled. Verified all 1,331 Codex external lock records remained unchanged, both Linux architectures resolve offline with an empty Cargo cache, and the documented Bubblewrap release build succeeds using Rust 1.95 with networking disabled.
The actual Codex dependency archive adds 293 MB compressed. No source archive or audit inventory is committed.
ARM64 image builds and the complete live-Docker suite remain unverified. The suite launcher rejects this macOS host; the Linux qualification host has Docker but no host Rust toolchain. The retained Tiktoken lock describes the image's new source build; it does not reconstruct historical upstream wheels. The retained source sets are conservative closures, not linker-level proof of every binary's contents.
Tiktoken qualification on native AMD64 and ARM64 compared the rebuilt and published wheels across four encodings, each with 1,011 texts covering Unicode, special tokens, batching, and round trips. Results matched on both architectures with network disabled for the rebuilt-wheel run. All vendored file checksums matched the 27-package lock. Both affected AMD64 runtime images contain the exact rebuilt extension and retain its wheel hash, lock, and matching sources.
A post-fix AMD64 scan of ELF files under
/opt/fabricfound no unmatched versioned Rust source paths: 1,420 per-binary crate references across 32 binary instances in the four qualified images were covered by retained sources. This checks embedded references, not stripped code or complete non-Cargo linkage.