Skip to content

ci(release): attach the tested version set as version-pins.json - #14759

Merged
cv merged 3 commits into
v1from
fix/14722-publish-the-tested-version-set
Nov 22, 2026
Merged

cv merged 3 commits into
v1from
fix/14722-publish-the-tested-version-set

Conversation

@deepujain

@deepujain deepujain commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Each staged release attaches version-pins.json, which lists the version and digest or checksum of each component that a deployment of the release uses. Teams that write their own HCL, or install a release without the CLI, can read the tested set from the release instead of copying versions.json from the repository at the release's tag.

Problem

A release attaches its CLI archives and SHA256SUMS, and its notes list the digests of the images it staged, but it doesn't say which OpenTofu, Docker and Helm providers, OpenShell gateway and chart, or Fabric revision it was tested with. Those pins are only in the repository's versions.json, beside tools that only build and test NemoClaw, such as Rust, protoc, nextest, and kind. The guide for hand-written HCL tells readers to fetch versions.json from the tag, and examples/kubernetes/hosted-nvidia.tf reads a copy of it.

Resolves #14722.

Change

  • nemoclaw-build release-pins --versions FILE --inventory FILE --tag TAG prints the pins:
    • From versions.json: OpenTofu and the Docker and Helm providers, with each platform's archive URL and SHA-256; the OpenShell gateway, supervisor, and sandbox images and Helm chart, by digest, with the OpenShell version; the development issuer image; and the Fabric source archive, with its revision.
    • From inventory.json: each image the release staged, by index digest, with the tag as its version.
    • It refuses a component that is missing or not pinned by digest or checksum, an empty inventory, and an image listed twice or under a component's name, so a release never carries a partial file.
  • The stage job writes the file after it creates every image index, adds a "Version pins" section to the release notes, and uploads the file beside SHA256SUMS.
  • Before publishing a final release, the assess job writes the pins again with the trusted controller, from the tag's versions.json and the inventory.json that matches staging's checksum. When the draft's file differs, the job stops before the security assessment and nothing is published.
  • The compatibility page describes the file's format, the HCL guide points to it, and the limit row for Publish the tested version set with each release #14722 is removed. The staging guide and the release candidate notes cover it too.

No maintainer has settled the file's format. It is one components map, keyed by the names versions.json already uses, such as gateway, gatewayChart, and opentofu, and by image name for the release's images. Each entry has one pin, image, chart, archives, or source, and a version where one is recorded. HCL that reads versions.json today keeps the same names, every component is looked up the same way, and each entry says how its bytes are fixed.

Left out:

  • Attesting version-pins.json. A final release attests its images, CLI archives, and SHA256SUMS; the controller compares the pins file before publication.
  • NemoClaw's own providers, which ship inside the CLI archives that SHA256SUMS covers.
  • Switching examples/kubernetes/hosted-nvidia.tf to the new file; its integration test supplies versions.json.
  • A comparison step for release candidates. Staging writes their file from the same inputs in the same step, and the check runs for final releases, which are the ones that publish.

Beyond CI

No release was staged, so the new staging and assess steps haven't run on a real tag. Tests run the assess step's script only against fake gh, git, and cargo commands. The first release candidate tagged after merge is the first end-to-end run.

Each staged release now attaches version-pins.json, the version and
digest or checksum of each component that a deployment of the release
uses: OpenTofu, the Docker and Helm providers, the OpenShell gateway,
supervisor, sandbox, and Helm chart, the development issuer, Fabric,
and the release's own agent and runtime images. Hand-written HCL can
read it instead of copying versions.json from the release's tag.

nemoclaw-build release-pins writes the file from the tag's
versions.json and the staged inventory.json. It leaves out tools that
only build and test NemoClaw, such as Rust, protoc, nextest, and kind,
and fails when a component is missing or isn't pinned by digest or
checksum. Before a final release is published, the trusted controller
writes the pins again from the same inputs, and the release stops when
the draft's file differs.

The compatibility page describes the file, the release notes gain a
section about it, and the limit row for #14722 is removed.

Resolves #14722

Signed-off-by: Deepak Jain <deepujain@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 21, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the v1 NemoClaw v1 branch label Nov 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@deepujain
deepujain marked this pull request as ready for review November 21, 2026 23:08
cv added 2 commits November 21, 2026 17:49
Return the file's text from release_pins::pins so its types stay private,
build components through Pin::at and one loop for the OpenShell pins,
read imageSources as images::SourcePins, set up the assess-step test's
fixture once, use the crate's hex helper, and write the release notes'
section with echo like the rest of the step.
@cv

cv commented Nov 22, 2026

Copy link
Copy Markdown
Collaborator
Authoring session — simplification commits c3cecca

Report for the session that wrote 8587021a04 and c3cecca873 on top of the author's 580c48e637. It doesn't replace the PR author's opening report.

Field Status Value Evidence or limit
Harness recorded Pi 1.6.0 Install path in the recorded system prompt
Skills recorded safe-refactoring (complete read); nemoclaw-contributor-create-pr (complete read); nvidia-style-guide SKILL.md (complete read) Tool reads in the session record to cutoff
Instruction files recorded AGENTS.md (injected); WRITING.md (complete read); .github/PULL_REQUEST_TEMPLATE.md (complete read); .github/SESSION_REPORT_TEMPLATE.md (complete read) Startup injection and tool reads to cutoff
Tool calls recorded typescript: 50 Wrapper calls to cutoff, including 1 failed; the wrapper hides nested shell, git, and gh calls
Tokens recorded input: 5194670; cached input: 5050918; output: 46633 Sum of assistant message usage (input + cacheRead + cacheWrite; cacheRead; output) to cutoff
Session window recorded 2026-11-22T00:42Z to 2026-11-22T00:57Z; 15 min Session start to the last assistant message before posting, including idle time
Compactions recorded 0 Complete record to cutoff
Models recorded claude-opus-5-5 Model change event; no changes
Reasoning levels recorded high Thinking level event; no changes

@cv
cv enabled auto-merge (squash) November 22, 2026 00:59
@cv
cv merged commit 5e1e488 into v1 Nov 22, 2026
110 of 112 checks passed
@cv
cv deleted the fix/14722-publish-the-tested-version-set branch November 22, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1 NemoClaw v1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants