Repository navigation
ci(release): attach the tested version set as version-pins.json - #14759
Merged
Merged
Conversation
Each staged release now attaches version-pins.json, the version and digest or checksum of each component that a deployment of the release uses: OpenTofu, the Docker and Helm providers, the OpenShell gateway, supervisor, sandbox, and Helm chart, the development issuer, Fabric, and the release's own agent and runtime images. Hand-written HCL can read it instead of copying versions.json from the release's tag. nemoclaw-build release-pins writes the file from the tag's versions.json and the staged inventory.json. It leaves out tools that only build and test NemoClaw, such as Rust, protoc, nextest, and kind, and fails when a component is missing or isn't pinned by digest or checksum. Before a final release is published, the trusted controller writes the pins again from the same inputs, and the release stops when the draft's file differs. The compatibility page describes the file, the release notes gain a section about it, and the limit row for #14722 is removed. Resolves #14722 Signed-off-by: Deepak Jain <deepujain@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14759.docs.buildwithfern.com/nemoclaw |
deepujain
marked this pull request as ready for review
November 21, 2026 23:08
Return the file's text from release_pins::pins so its types stay private, build components through Pin::at and one loop for the OpenShell pins, read imageSources as images::SourcePins, set up the assess-step test's fixture once, use the crate's hex helper, and write the release notes' section with echo like the rest of the step.
Collaborator
Authoring session — simplification commits c3ceccaReport for the session that wrote
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each staged release attaches
version-pins.json, which lists the version and digest or checksum of each component that a deployment of the release uses. Teams that write their own HCL, or install a release without the CLI, can read the tested set from the release instead of copyingversions.jsonfrom the repository at the release's tag.Problem
A release attaches its CLI archives and
SHA256SUMS, and its notes list the digests of the images it staged, but it doesn't say which OpenTofu, Docker and Helm providers, OpenShell gateway and chart, or Fabric revision it was tested with. Those pins are only in the repository'sversions.json, beside tools that only build and test NemoClaw, such as Rust, protoc, nextest, and kind. The guide for hand-written HCL tells readers to fetchversions.jsonfrom the tag, andexamples/kubernetes/hosted-nvidia.tfreads a copy of it.Resolves #14722.
Change
nemoclaw-build release-pins --versions FILE --inventory FILE --tag TAGprints the pins:versions.json: OpenTofu and the Docker and Helm providers, with each platform's archive URL and SHA-256; the OpenShell gateway, supervisor, and sandbox images and Helm chart, by digest, with the OpenShell version; the development issuer image; and the Fabric source archive, with its revision.inventory.json: each image the release staged, by index digest, with the tag as its version.SHA256SUMS.versions.jsonand theinventory.jsonthat matches staging's checksum. When the draft's file differs, the job stops before the security assessment and nothing is published.No maintainer has settled the file's format. It is one
componentsmap, keyed by the namesversions.jsonalready uses, such asgateway,gatewayChart, andopentofu, and by image name for the release's images. Each entry has one pin,image,chart,archives, orsource, and aversionwhere one is recorded. HCL that readsversions.jsontoday keeps the same names, every component is looked up the same way, and each entry says how its bytes are fixed.Left out:
version-pins.json. A final release attests its images, CLI archives, andSHA256SUMS; the controller compares the pins file before publication.SHA256SUMScovers.examples/kubernetes/hosted-nvidia.tfto the new file; its integration test suppliesversions.json.Beyond CI
No release was staged, so the new staging and assess steps haven't run on a real tag. Tests run the assess step's script only against fake
gh,git, andcargocommands. The first release candidate tagged after merge is the first end-to-end run.