Skip to content

fix(release): normalize macOS signing payload permissions - #14758

Merged
prekshivyas merged 6 commits into
v1from
prekshiv/macos-3s-signing-v1
Nov 21, 2026
Merged

prekshivyas merged 6 commits into
v1from
prekshiv/macos-3s-signing-v1

Conversation

@prekshivyas

@prekshivyas prekshivyas commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Normalize macOS signing payloads to mode 0755 before adding them to the ZIP submitted to 3S.

Problem

The private runner extracts bundles under umask 077, leaving executables with mode 0700. The helper copies those permissions into its upload. A live 3S request contained a valid arm64 Mach-O as payload.command with ZIP mode 0700; the service listed the file but did not select it for signing, then attempted to sign its scripts directory and failed. Fleet's working reference explicitly makes its payload 0755 before zipping.

Part of #14621; follow-up to #14739 and #14757.

Change

Set the copied payload to 0755 before packaging without changing its bytes. Keep private scratch directories at 0700 and leave the runner's restrictive umask in place.

Beyond CI

Read the actual failed request's input ZIP and signing log through the CI identity: the input was a 44,041,952-byte arm64 Mach-O with mode 0700. Missing entitlements was informational; the signing error named the service's scripts directory as an unsuitable bundle. A live validation changing only ZIP member permissions to 0755 signed all eight NVIDIA-designated executables. The hosted Mac job verified every signature against the expected NVIDIA or HashiCorp team; notarization stayed disabled. That validation used a temporary runner wrapper, which was removed afterward; validating the release workflow with this source fix and no wrapper still remains.

@github-actions github-actions Bot added the v1 NemoClaw v1 branch label Nov 21, 2026
@prekshivyas

Copy link
Copy Markdown
Collaborator Author
Authoring session — opening
Field Status Value Evidence or limit
Harness recorded Codex Desktop, CLI 0.163.0-alpha.11.1 Persisted authoring metadata and matching repository activity.
Skills partial nemoclaw-contributor-create-pr; clss-bm-remote; managing-confluence; managing-glean Complete reads in the task interval. Earlier inherited guidance excluded.
Instruction files partial v1 AGENTS.md; SESSION_REPORT_TEMPLATE.md Complete reads in this task interval; earlier instruction reads excluded.
Tool calls partial exec: 113; sleep: 16 Attempted wrapper calls, including failures; nested invocations excluded from these counts. Includes earlier client fix and live troubleshooting in the same task.
Tokens partial input: 25328548; cached input: 25239552; output: 49579 Delta of actual cumulative counters to 2026-11-21T21:31:56.748Z; no in-interval resets. In-flight response usage may be missing.
Session window partial 2026-11-21T20:54:44.147Z to 2026-11-21T21:32:15.205Z Task-only interval, including idle time, earlier #14757 work, and live troubleshooting; earlier setup and later publication excluded.
Compactions recorded 0 Persisted records in this interval.
Models recorded gpt-6.1-sol Persisted turn contexts.
Reasoning levels recorded medium Persisted turn contexts.

The permission regression reproduced the incorrect mode before the change. All ten standalone helper tests passed after the fix, and rustfmt, warning-free compilation and whitespace checks passed. A macOS local file-copy probe alone did not reproduce the Linux upload mode; the actual 3S input ZIP established mode 0700.

The service-input and log lookups used existing-request reads through the configured CI/Vault identity, not new signing submissions. A later experiment normalizes only ZIP member permissions before the real client submission; its result is pending at this cutoff and does not establish operation of the unmodified release helper. No successful signed archive or notarization is claimed.

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Selected hardware E2Es

Commit: 308dc650e16539234dcd366e4b09773438047860

No hardware E2Es selected by changed-file rules.

@prekshivyas
prekshivyas merged commit c30c3f1 into v1 Nov 21, 2026
80 of 81 checks passed
@prekshivyas
prekshivyas deleted the prekshiv/macos-3s-signing-v1 branch November 21, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1 NemoClaw v1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant