Repository navigation
fix(release): normalize macOS signing payload permissions - #14758
Conversation
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Authoring session — opening
The permission regression reproduced the incorrect mode before the change. All ten standalone helper tests passed after the fix, and rustfmt, warning-free compilation and whitespace checks passed. A macOS local file-copy probe alone did not reproduce the Linux upload mode; the actual 3S input ZIP established mode 0700. The service-input and log lookups used existing-request reads through the configured CI/Vault identity, not new signing submissions. A later experiment normalizes only ZIP member permissions before the real client submission; its result is pending at this cutoff and does not establish operation of the unmodified release helper. No successful signed archive or notarization is claimed. |
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14758.docs.buildwithfern.com/nemoclaw |
Selected hardware E2EsCommit: No hardware E2Es selected by changed-file rules. |
Normalize macOS signing payloads to mode
0755before adding them to the ZIP submitted to 3S.Problem
The private runner extracts bundles under umask
077, leaving executables with mode0700. The helper copies those permissions into its upload. A live 3S request contained a valid arm64 Mach-O aspayload.commandwith ZIP mode0700; the service listed the file but did not select it for signing, then attempted to sign its scripts directory and failed. Fleet's working reference explicitly makes its payload0755before zipping.Part of #14621; follow-up to #14739 and #14757.
Change
Set the copied payload to
0755before packaging without changing its bytes. Keep private scratch directories at0700and leave the runner's restrictive umask in place.Beyond CI
Read the actual failed request's input ZIP and signing log through the CI identity: the input was a 44,041,952-byte arm64 Mach-O with mode
0700. Missing entitlements was informational; the signing error named the service's scripts directory as an unsuitable bundle. A live validation changing only ZIP member permissions to0755signed all eight NVIDIA-designated executables. The hosted Mac job verified every signature against the expected NVIDIA or HashiCorp team; notarization stayed disabled. That validation used a temporary runner wrapper, which was removed afterward; validating the release workflow with this source fix and no wrapper still remains.