Skip to content

fix(e2e): install pinned protoc for standard targets - #14751

Open
prekshivyas wants to merge 1 commit into
mainfrom
codex/e2e-standard-pinned-protoc
Open

prekshivyas wants to merge 1 commit into
mainfrom
codex/e2e-standard-pinned-protoc

Conversation

@prekshivyas

@prekshivyas prekshivyas commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Outcome

Standard E2E targets install the pinned v1 protoc before preparing the workspace. Their config-export checks can build the Rust parser instead of failing because the compiler is absent.

Reason

Hermes security job 136822303481 exported both CLI aliases successfully, then failed the pinned parser build with Could not find protoc. The shared standard profile omitted the prerequisite already installed by dedicated E2E jobs. This workflow omission also exists on the recorded main commit.

Related issues

Refs #12603.

Changes

  • Reuse the existing setup-v1-protoc action from accepted main commit c474038df67fcb22182298ac9a696c81e63f0ee2. Its four Linux/macOS archive hashes match the pinned parser manifest.
  • Require that immutable action and its position in the workflow-boundary validator. Reject conditions, extra inputs, environment injection, ignored errors, and altered pins.
  • Cover omitted, moved, local, mutable, and otherwise altered setup through the existing validator tests. Keep all live assertions, deadlines, and qualification gates.

Verification

  • vitest run --project e2e-support test/e2e/support/standard-profile-workflow-boundary.test.ts test/e2e/support/v1-parse-consumer.test.ts --maxWorkers=1 — 36 passed in credential-free, network-denied native isolation.
  • Oxfmt and Oxlint on the three changed TypeScript files — passed.
  • Inspected the complete failed job log, retained export artifact, installer, pinned parser manifest, and affected caller/setup paths.
  • Reviewed the diff: no secrets, API keys, or credentials.

Review notes

Sensitive paths: .github/workflows/e2e-standard-profile.yaml and the validators under tools/e2e/. Pre-publication review consists of the authoring agent's four-file self-review and focused validation against main c474038df67fcb22182298ac9a696c81e63f0ee2; independent review is pending. The PR remains draft during CI and automated review. Full E2E qualification remains pending; this prerequisite does not resolve the other failures in #12603.


Signed-off-by: Prekshi Vyas prekshiv@nvidia.com

Summary by CodeRabbit

  • Chores
    • Updated the standard end-to-end test workflow to set up a pinned Protocol Buffers compiler before downloading the SDK.
    • Added checks to ensure the setup action and its position in the workflow remain consistent.

Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 21, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The standard E2E profile now runs a pinned protoc setup action before downloading the SDK archive. The workflow boundary validator checks the action reference and step order.

Changes: Standard E2E protoc setup

Layer / File(s) Summary
Pinned protoc setup and provenance
tools/e2e/workflow-boundary-policy.mts, .github/workflows/e2e-standard-profile.yaml
The workflow adds the pinned protoc action after host dependency installation. The provenance policy records its commit reference.
Workflow boundary enforcement
tools/e2e/standard-profile-workflow-boundary.mts, test/e2e/support/standard-profile-workflow-boundary.test.ts
The validator checks the protoc step’s name, action reference, and position. Tests cover altered fields, a removed step, and a moved step.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: ericksoa, cjagwani, rsliter

Merge Risk: Minimal · up to c310c

This change installs a pinned protoc in the standard E2E profile so the config-export parser build can run. It also adds validator checks and tests that guard the step. The risk is limited to CI workflows, and no merge-blocking issue was found.

Security architecture risk: Minimal · up to c310c

The added compiler setup is pinned to an exact commit, verifies downloaded archives, and must complete before workspace preparation. The inspected change does not establish an introduced or worsened security, ownership, or failure-containment risk.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The added dependency executes with the existing E2E runner's authority after Docker authentication and can affect subsequent commands through PATH. Its relevant exposure is therefore the workflow job and its existing resources, not an isolated compiler process. The PR does not add token permissions or secret mappings.

Trust Boundaries and Controls

  • observed — The action invokes its own pinned installer using runner platform identifiers, not a workspace-selected script or caller-provided URL. Fixed archive digests constrain downloaded executable content. Static validation additionally requires the complete protoc step to equal the reviewed name and action reference, rejecting conditions, environment injection, extra inputs, ignored failures, and replacement commands.

Resilience and Maintainability Implications

  • observed — The exact ordered-step-list check and single-step requirement reject omitted, duplicated, or relocated protoc setup. Mutation tests cover omission and late placement. These controls detect workflow drift through validation errors; they are not runtime enforcement, and required CI execution was not verified.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix(e2e): install pinned protoc for standard targets" matches the main change. The PR adds the pinned v1 protoc setup step to the standard E2E profile workflow, before the OpenShell SDK dow…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(e2e): install pinned protoc for standard targets" matches the main change. The PR adds the pinned v1 protoc setup step to the standard E2E profile workflow, before the OpenShell SDK download. It also adds validator rules and tests for that step. The title is short, specific, and uses a conventional commit prefix. It does not cover the validator and test additions, but it does not need to.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c474038 and c310ceb.

Files selected for processing: 4

  • .github/workflows/e2e-standard-profile.yaml
  • test/e2e/support/standard-profile-workflow-boundary.test.ts
  • tools/e2e/standard-profile-workflow-boundary.mts
  • tools/e2e/workflow-boundary-policy.mts

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@prekshivyas

Copy link
Copy Markdown
Collaborator Author
Authoring session — opening
Field Status Value Evidence or limit
Harness recorded Codex Desktop, CLI 0.163.0-alpha.11.1 Persisted authoring metadata; branch and four-file edit match this chat.
Skills partial nemoclaw-contributor-create-pr; nemoclaw-contributor-implement-issue; nemoclaw-contributor-onboard; nemoclaw-contributor-update-docs; nemoclaw-maintainer-audit-e2e-assertions; nemoclaw-maintainer-classify-ci-failure; nemoclaw-maintainer-e2e; nemoclaw-maintainer-find-review-pr; nemoclaw-maintainer-fix-e2e-failures; nemoclaw-maintainer-security-code-review Complete current-byte reads verified in persisted outputs. Earlier versions and fragmented reads cannot be fully inventoried.
Instruction files partial .agents/references/development.md; .agents/references/e2e-authoring.md; .agents/skills/_shared/documentation-writing-review.md; .agents/skills/_shared/git-github-hard-stop.md; .agents/skills/_shared/implementation-discovery.md; .agents/skills/_shared/pr-follow-up.md; .agents/skills/_shared/root-cause-and-state-checks.md; .agents/skills/_shared/security-rubric.md; .agents/skills/_shared/task-continuation.md; .github/PULL_REQUEST_TEMPLATE.md; .github/SESSION_REPORT_TEMPLATE.md; AGENTS.md; CONTRIBUTING.md; WRITING.md; test/README.md Complete current-byte matches only; earlier versions, fragmented reads and startup injections are not exhaustively recoverable.
Tool calls partial exec: 8534; sleep: 339; wait: 34 Attempted calls at the recorded wrapper layer, including failures. Nested exec invocations are not fully observable and are not added to these counts.
Session window recorded 2026-11-18T18:40:16.936Z to 2026-11-21T11:37:34.626241Z; 233837.69 seconds including idle time Whole chat through cutoff, including earlier OpenShell upgrade work. No task-only duration or inherited activity split inferred.
Compactions recorded 57 Explicit compaction events through cutoff.
Models recorded gpt-6.1-sol Recorded model history through cutoff.
Reasoning levels recorded medium Recorded effort history through cutoff.

@github-code-quality

github-code-quality Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage/plugin

main 63002cd codex/e2e-standard-p... c310ceb +/-
96% 97% +1%
View coverage of the 10 most impacted files.
File main 63002cd codex/e2e-standard-p... c310ceb +/-
nemoclaw/src/sh...cy-boundary.cts 100% 97% -3%
nemoclaw/src/onboard/config.ts 98% 96% -2%
nemoclaw/src/ru...time-context.ts 100% 99% -1%
nemoclaw/src/bl...print/runner.ts 95% 95% 0%
nemoclaw/src/bl...ime-identity.ts 97% 97% 0%
nemoclaw/src/bl...t-management.ts 100% 100% 0%
nemoclaw/src/index.ts 94% 99% +5%
nemoclaw/src/de...search-state.ts 0% 100% +100%
nemoclaw/src/on...native-route.ts 0% 100% +100%
nemoclaw/src/search-config.ts 0% 100% +100%

TypeScript / code-coverage/cli

main 63002cd codex/e2e-standard-p... c310ceb +/-
84% 86% +2%
View coverage of the 10 most impacted files.
File main 63002cd codex/e2e-standard-p... c310ceb +/-
src/lib/onboard.ts 62% 50% -12%
src/lib/actions...ess-recovery.ts 65% 83% +18%
src/lib/inferen...ollama/proxy.ts 41% 61% +20%
src/lib/onboard.../application.ts 55% 84% +29%
src/lib/domain/...y/dimensions.ts 0% 75% +75%
src/lib/inferen...er/lifecycle.ts 0% 75% +75%
src/lib/actions...ry/operation.ts 0% 76% +76%
src/lib/actions...try/snapshot.ts 0% 84% +84%
src/lib/inferen...ovider/index.ts 0% 90% +90%
src/lib/hermes-...yard-routing.ts 0% 95% +95%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 21, 2026 12:04 UTC

@prekshivyas

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit c310ceb. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

Request review only when Require no Advisor blockers is green.

All previous runs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant