Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
Authoring session — opening
|
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14702.docs.buildwithfern.com/nemoclaw |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
examples/scenarios.md, a table of deployment scenarios in which each row names an example and what the machine needs, and a live test,scenarios::page, that runs every row the machine can run. Each row it runs goes through plan, apply, a reply check, an unchanged plan, and destroy; each row it can't run is reported as skipped with the need the machine lacks.Problem
The scenario matrix for GTC DC lives in a spreadsheet, and the examples it names are checked by hand on each machine.
The repository has live HCL cases, but each case is its own document and
tofu testfile, so a docs table of scenarios and the tests that run them are kept in sync by hand, and nothing says which rows a given machine can run.Change
examples/scenarios.md: one table, with the columns Scenario, Example (a link), Needs, Model, Ask, and Expect. Needs uses a small vocabulary:linux,wsl2,arm64,amd64,docker,gpu NAME,kubernetes, and$NAMEfor a credential.Model: stubserves the stub model in place of every endpoint, so the row needs no GPU or credential.crates/nemoclaw-e2e/tests/e2e/scenarios.rs:REPO:TAGbuilds.hcl_live::case.crates/nemoclaw-e2e/tests/e2e/hcl/scenarios/lifecycle.tftest.hcl: one lifecycle shared by every row, reusing thecli,verifier, andmodelmodules. The row arrives asTF_VAR_scenario. Themodelmodule gains optionalportandenabledvariables; existing cases are unchanged.Rejected alternatives:
tofu testfile per row. The lifecycle is the same for every row, so generating files would add a sync step without checking anything new.Deliberately left out:
cargo ci live-dockeronce the runner takes that job's image names.Beyond CI
NVIDIA_API_KEY.