Repository navigation
test(e2e): add recent-release upgrade qualification - #14335
Conversation
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Authoring session — opening
The active authoring scope started with the upgrade-contract task after inherited parent history. |
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/plugin
View coverage of the 10 most impacted files.
TypeScript / code-coverage/cli
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
|
Complete review for The Advisor aggregate fails only for one operability E2E request that treats a manual-only job as unsupported. The captured inventory includes The new v0.0.141 target is intentionally unavailable in trusted-main selection until catalogue admission. PR #14276 also remains a prerequisite. I did not add a new test, override the trusted planner, request CodeRabbit, retry a policy rejection, or change code to satisfy the unsupported-selector claim. No additional revision cycle was consumed. Live qualification and eligible human review remain outstanding. This comment records the disposition; it does not convert the failed Advisor aggregate into a passing check or claim successful runtime evidence. |
…nt (NVIDIA#14276) Prepare and revalidate a safe OpenShell replacement destination before retiring the old gateway. Preserve the selected executable handoff, historical fixture bytes, and upgrade-state assertions. Refs NVIDIA#14268. Recent-release qualification remains in NVIDIA#14335. Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
Consume the merged OpenShell destination and workspace-marker fixes. Retain main executable preparation and planner inventory while adding the pinned v0.0.141 running and stopped sandbox upgrade fixture. Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
|
Review disposition for Eight finding ledgers are clear. I decline reduction finding Seven unresolved E2E requests identify the same accepted recent-upgrade boundary. The existing manual-only The Advisor aggregate remains failed for its reported finding and unresolved recommendations. This disposition does not claim a passing aggregate or completed live qualification. No additional code revision was made. Independent security review of all seven changed files on this commit passed all nine repository rubric categories. It verified immutable archive/bootstrap pins, server-enforced ordinary |
|
E2E evidence for E2E run 43313902305, attempt 1: SUCCESS, including
All six execution archives were hash-verified against GitHub metadata and bound to this source commit and run. Required assertion outcomes, phases and registered cleanup callbacks passed. The v0.0.123 case restored both additional stopped sandboxes, verified their workspace markers and returned them to stopped state. Cleanup verification covers each fixture’s named resources and registered callbacks. The global dispatch input was The new v0.0.141 row is absent from trusted pre-merge selection. Its first live qualification follows catalogue admission under the recorded sequence. These historical passes do not qualify v0.0.141. Keep #14268 open until the new case passes. |
prekshivyas
left a comment
There was a problem hiding this comment.
Reviewed commit 3a7f9b2. No actionable code findings. The new v0.0.141 fixture still requires live qualification after catalogue admission; historical E2E passes do not qualify it.
Outcome
The upgrade catalogue gains a pinned v0.0.141 fixture with one running and one stopped sandbox. It reuses the existing scenario, which requires workspace preservation, authenticated agent turns, usable gateway access, and terminal cleanup. Live qualification remains pending.
Reason
Issue #14268 requires recent-release upgrade evidence in addition to historical component-replacement migrations. The new fixture covers reuse of the compatible OpenShell 0.0.116 runtime. The v0.0.89 and v0.0.123 fixtures retain their distinct migration coverage.
Related issues
Refs #14268. Builds on merged #14276 for the destination and workspace-marker repairs. ACP prefix migration is already merged through #12830.
Changes
Verification
Candidate:
3a7f9b223704e6a3026327053e57e33294895fb6. The branch is synchronized with canonical main2822077e58a57d160b567886a939fefe5ecacef7, which contains #14276. The two mechanical conflicts retain main's private executable preparation and current catalogue inventory while adding the recent fixture.node_modules/.bin/vitest run --project e2e-support test/e2e/support/openshell-gateway-upgrade-old-installer.test.ts test/e2e/support/openshell-gateway-upgrade-workflow-boundary.test.ts test/e2e/support/workflow-plan.test.ts --maxWorkers=1: 212 passed across three files in a credential-isolated clone. Canonical main was reverified immediately before execution.git diff --check --cachedpassed. The merged files match the independently reviewed seven-file proposal. No live assertion, timeout, retry policy or assertion budget changed.Installed pre-commit and commit-message hooks passed inside the verified credential-isolation boundary. The signed merge commit includes DCO. The actual installed pre-push hook passed publication validation and plugin, JavaScript-config and CLI type checks inside the same boundary. GitHub verifies both published commits.
Independent review of the seven-file merge proposal found no actionable defect. The v0.0.141 release commit and bootstrap checksum, OpenClaw archive integrity and native RPC compatibility were verified. Historical fixtures, credential custody, successful authenticated responses, MCP cleanup, workspace checks and stopped-sandbox restoration remain intact.
Diff review found no secrets, API keys, credentials or unrelated candidate changes.
Code CI passed, including all 12 CLI shards and their aggregate.
All nine specialist artifacts in Advisor run 43311296576 were verified against this candidate, base, trusted workflow and v26 plan. Eight finding ledgers are clear. The single builder refactor was declined as optional after source review and independent review found no incorrect metadata or behavior. Complete disposition.
Focused E2E run 43313902305 passed:
cloud-onboard,full-e2e, bothsecurity-posturevariants and both trustedopenshell-gateway-upgradehistorical rows. All six source-bound archives, required assertions, phases and registered cleanup callbacks were verified. The relevant-E2E aggregate passed; full release qualification was not selected.The new v0.0.141 live qualification remains a post-catalogue-merge step. Pre-merge historical results do not qualify that new row.
Review notes
Sensitive paths:
tools/e2e/openshell-gateway-upgrade-fixture.mtsandtools/e2e/target-catalogue.mtsin NVIDIA/NemoClaw. An independent subagent reviewed all seven files against canonical main2822077e58a57d160b567886a939fefe5ecacef7, including release/bootstrap/archive pins, native RPC compatibility and preservation of the historical fixture and cleanup contracts. It found no actionable issue. This review is pre-publication evidence; it does not replace CI or eligible maintainer review.Validation runs in a private clone with private dependencies and cache. Host credential files, credential helpers, secret environment variables, and outside sockets are blocked. Installed packages and hook files are read-only; generated source-cache writes are permitted only inside the private clone. Git signing and authenticated transport remain outside this boundary. No validation policy is waived.
Manual PR selection reads the catalogue from trusted main. The new selector
openshell-gateway-upgrade-v0-0-141-x86-64becomes selectable after catalogue admission. Its first live qualification follows that admission; keep #14268 open until qualification succeeds. #14276 is merged and its destination/workspace-marker fixes are included. No planner override is used. The current Advisor aggregate remains failed for its optional builder finding and seven unresolved requests for the same gateway qualification boundary. The source and independent-review disposition is linked above. The manual-only gateway job is supported; the pre-merge run uses the trusted v0.0.89/v0.0.123 rows. The new v0.0.141 row follows catalogue admission and its first trusted live qualification. No planner override or status-check waiver is used.Signed-off-by: Rebecca Sliter 571084+rsliter@users.noreply.github.com
Summary by CodeRabbit
Tests
Documentation