Repository navigation
test(e2e): diagnose provider selection and first-reply latency #14270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+1,010
−184
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
77ff75d
fix(ci): authorize candidate testing through PR reviews
rsliter 9729720
test(ci): verify review handoff and comparison failures
rsliter eca5ab9
docs(e2e): align protected runtime review scope
rsliter d043bd0
docs(ci): describe review signal token permissions accurately
rsliter b363eb8
docs(ci): clarify when approved candidate SDKs are packaged
rsliter f9a84a0
fix(ci): invalidate review after projection policy changes
rsliter 3f770a4
fix(ci): include SDK projection policy in workspace admission
prekshivyas 4ac7414
test(e2e): retain provider and first-reply timing diagnostics
rsliter 99c8070
test(e2e): map provider timing fixtures to fast coverage
rsliter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # This PR-context workflow only wakes the default-branch admission controller. | ||
| # It uses permissions: {} and has no checkout, artifacts, or admission authority. | ||
| name: Security / Candidate Review Signal | ||
| on: | ||
| pull_request_review: | ||
| types: [submitted, edited, dismissed] | ||
| permissions: {} | ||
| jobs: | ||
| signal: | ||
| if: ${{ github.repository == 'NVIDIA/NemoClaw' && github.event.pull_request.base.ref == 'main' && github.event.pull_request.head.repo.full_name == 'NVIDIA/NemoClaw' }} | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 1 | ||
| steps: | ||
| - name: Signal a review change | ||
| run: echo 'Candidate admission will read the current PR reviews.' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 18002
Web query:
GitHub Actions workflow_run completed skipped workflow trigger skipped jobs head_repository pull_request_review workflow contextResult:
Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 11662
Web query:
GitHub Actions pull_request_review workflow run head_repository fork pull request review head_branch workflow_run payloadResult:
Web query:
GitHub Actions pull_request_review GITHUB_REF GITHUB_SHA merge branch workflow run fork head_repositoryResult:
Web query:
GitHub workflow_run payload head_repository for pull_request_review event fork pull request exact semanticsResult:
Filter fork-originated review signals before starting admission.
The signal workflow skips fork pull requests, but its completed run can still trigger this workflow. The current job condition accepts that
workflow_run, and the identity script then fails withInvalid candidate review signal. Add the head-repository check to the job condition. Do not filter onconclusion; failed signal runs must still re-evaluate admission.Suggested fix
Committable suggestion