Repository navigation
Conversation
The SDK producer in main E2E packages the replacement SDK listed in ci/reviewed-npm-audit.json. #13183 changed that replacement from 0.1.2 to 0.1.3, but the pinned install action still read the 697af6e config, which allows only 0.0.116 and 0.1.2. Every E2E job then failed with "reviewed OpenShell SDK artifact directory has unexpected contents". Pin the install action to 2584abf, where the trusted config lists 0.1.3. The action content is unchanged, so its content hash stays. Signed-off-by: San Dang <sdang@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/plugin
View coverage of the 10 most impacted files.
TypeScript / code-coverage/cli
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Main E2E jobs get past "Install reviewed OpenShell SDK archive without package credentials" again. Since #13183, all 67 jobs that reached this step in run 38760971100 failed there with
reviewed OpenShell SDK artifact directory has unexpected contents.Reason
The E2E SDK producer packages the base SDK and the replacement SDK listed in
ci/reviewed-npm-audit.json. #13183 changed the replacement from 0.1.2 to 0.1.3, so the uploaded artifact now holdsnvidia-openshell-sdk-0.0.116.tgzandnvidia-openshell-sdk-0.1.3.tgz. The install step runs the action pinned at697af6ed24. That commit's trusted config allows only 0.0.116 and 0.1.2, so it rejects the 0.1.3 archive.Related issues
Refs #13183. Refs #12603.
Changes
install-reviewed-openshell-sdkto2584abf0a4(the fix(e2e): admit reviewed candidate installer trust without workflow edits #13183 merge on main) in the foure2e.yamluses and ine2e-standard-profile.yaml.E2E_ACTION_PROVENANCE.reviewedSdkInstall.referenceintools/e2e/workflow-boundary-policy.mtsto match.action.yamlis identical at both commits, socontentSha256does not change.The pinned commit's trusted config lists 0.0.116 and 0.1.3. On push and dispatch events, and on PRs whose locks use a listed SDK, it skips candidate admission and stages the lock-selected 0.0.116 archive.
Verification
scripts/checks/prepare-ci-npm-install.mtsagainst the artifact from run 38760971100. At697af6ed24it exits 1 withunexpected contents, which reproduces the failure. At2584abf0a4it exits 0 and stages the archive.2584abf0a4(ci-install-dependencies.sh none artifactwith credentials unset, then the SDK import check). Result:sdk import ok.vitest run --project e2e-supportonopenshell-sdk-install,hermes-workflow-boundary,standard-profile-workflow-boundaryandjetson-managed-revision-boundary: 49 tests passed. The first run hit 5s cold-start timeouts in two tests, which passed on rerun.npm run validate:prpassed, including publication validation and CLI TypeScript.Nothing after the SDK install step ran in the failed run, so its later assertions have no evidence yet. The next main E2E run is the first to exercise them.
Review notes
Sensitive paths:
.github/workflows/e2e.yaml,.github/workflows/e2e-standard-profile.yaml,tools/e2e/workflow-boundary-policy.mts. There was no independent review before publication; these paths are awaiting maintainer review. The change only moves a pinned trusted-controller ref, following the precedent in #12765 (f880dd1→697af6e).Signed-off-by: San Dang sdang@nvidia.com