Skip to content

fix(e2e): pin SDK installer to the 0.1.3 trusted config - #13275

Closed
sandl99 wants to merge 1 commit into
mainfrom
fix/e2e-sdk-install-pin
Closed

sandl99 wants to merge 1 commit into
mainfrom
fix/e2e-sdk-install-pin

Conversation

@sandl99

@sandl99 sandl99 commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Outcome

Main E2E jobs get past "Install reviewed OpenShell SDK archive without package credentials" again. Since #13183, all 67 jobs that reached this step in run 38760971100 failed there with reviewed OpenShell SDK artifact directory has unexpected contents.

Reason

The E2E SDK producer packages the base SDK and the replacement SDK listed in ci/reviewed-npm-audit.json. #13183 changed the replacement from 0.1.2 to 0.1.3, so the uploaded artifact now holds nvidia-openshell-sdk-0.0.116.tgz and nvidia-openshell-sdk-0.1.3.tgz. The install step runs the action pinned at 697af6ed24. That commit's trusted config allows only 0.0.116 and 0.1.2, so it rejects the 0.1.3 archive.

Related issues

Refs #13183. Refs #12603.

Changes

The pinned commit's trusted config lists 0.0.116 and 0.1.3. On push and dispatch events, and on PRs whose locks use a listed SDK, it skips candidate admission and stages the lock-selected 0.0.116 archive.

Verification

  • Ran scripts/checks/prepare-ci-npm-install.mts against the artifact from run 38760971100. At 697af6ed24 it exits 1 with unexpected contents, which reproduces the failure. At 2584abf0a4 it exits 0 and stages the archive.
  • Ran the full step body with the action scripts from 2584abf0a4 (ci-install-dependencies.sh none artifact with credentials unset, then the SDK import check). Result: sdk import ok.
  • vitest run --project e2e-support on openshell-sdk-install, hermes-workflow-boundary, standard-profile-workflow-boundary and jetson-managed-revision-boundary: 49 tests passed. The first run hit 5s cold-start timeouts in two tests, which passed on rerun.
  • Commit hooks passed, including Repository checks, E2E semantic phase plans, growth guardrails and gitleaks.
  • npm run validate:pr passed, including publication validation and CLI TypeScript.
  • The diff contains no secrets, API keys or credentials.

Nothing after the SDK install step ran in the failed run, so its later assertions have no evidence yet. The next main E2E run is the first to exercise them.

Review notes

Sensitive paths: .github/workflows/e2e.yaml, .github/workflows/e2e-standard-profile.yaml, tools/e2e/workflow-boundary-policy.mts. There was no independent review before publication; these paths are awaiting maintainer review. The change only moves a pinned trusted-controller ref, following the precedent in #12765 (f880dd1 → 697af6e).


Signed-off-by: San Dang sdang@nvidia.com

The SDK producer in main E2E packages the replacement SDK listed in
ci/reviewed-npm-audit.json. #13183 changed that replacement from 0.1.2
to 0.1.3, but the pinned install action still read the 697af6e config,
which allows only 0.0.116 and 0.1.2. Every E2E job then failed with
"reviewed OpenShell SDK artifact directory has unexpected contents".

Pin the install action to 2584abf, where the trusted config lists
0.1.3. The action content is unchanged, so its content hash stays.

Signed-off-by: San Dang <sdang@nvidia.com>
@sandl99 sandl99 self-assigned this Oct 15, 2026
@copy-pr-bot

copy-pr-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage/plugin

main 63002cd fix/e2e-sdk-install-... d1edd09 +/-
96% 97% +1%
View coverage of the 10 most impacted files.
File main 63002cd fix/e2e-sdk-install-... d1edd09 +/-
nemoclaw/src/onboard/config.ts 98% 96% -2%
nemoclaw/src/index.ts 94% 93% -1%
nemoclaw/src/bl...print/runner.ts 95% 95% 0%
nemoclaw/src/bl...ime-identity.ts 97% 97% 0%
nemoclaw/src/bl...t-management.ts 100% 100% 0%
nemoclaw/src/co.../config-show.ts 100% 100% 0%
nemoclaw/src/commands/slash.ts 100% 100% 0%
nemoclaw/src/ru...time-context.ts 100% 100% 0%
nemoclaw/src/sh...er-boundary.cts 100% 100% 0%
nemoclaw/src/on...native-route.ts 0% 100% +100%

TypeScript / code-coverage/cli

main 63002cd fix/e2e-sdk-install-... d1edd09 +/-
84% 86% +2%
View coverage of the 10 most impacted files.
File main 63002cd fix/e2e-sdk-install-... d1edd09 +/-
src/lib/onboard.ts 62% 47% -15%
src/lib/actions...ess-recovery.ts 65% 78% +13%
src/lib/state/l...diness-lease.ts 66% 83% +17%
src/lib/inferen...ollama/proxy.ts 41% 61% +20%
src/lib/onboard.../application.ts 55% 84% +29%
src/lib/domain/...y/dimensions.ts 0% 71% +71%
src/lib/actions...ry/operation.ts 0% 76% +76%
src/lib/actions...try/snapshot.ts 0% 78% +78%
src/lib/inferen...ovider/index.ts 0% 88% +88%
src/lib/onboard...ternal-image.ts 0% 91% +91%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 15, 2026 16:54 UTC

@sandl99 sandl99 closed this Oct 15, 2026
@wscurran wscurran added area: ci CI workflows, checks, release automation, or GitHub Actions area: security Security controls, permissions, secrets, or hardening labels Oct 15, 2026
@cv
cv deleted the fix/e2e-sdk-install-pin branch November 21, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI workflows, checks, release automation, or GitHub Actions area: security Security controls, permissions, secrets, or hardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants