Repository navigation
Remove StorageClass override from installation builder - #45
Merged
Merged
Conversation
Use the cluster default in generated installation commands and remove the optional storage field and its obsolete test assertions. Chart-level storage configuration remains unchanged. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Member
Author
|
since we dont pin the rancher path one anymore just use the default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the optional StorageClass field and generated storage overrides from the installation command builder. Retain chart storage configuration. Validation: all 10 builder tests pass; strict Sphinx build passes; browser screenshot inspected and field absence verified.