Repository navigation
Add read-only Loki log discovery and queries - #44
Merged
Merged
Conversation
Expose bounded LogQL log queries and label discovery through the observability extension in View mode. Wire operator-configured endpoint, tenant, and Secret-backed authorization through Helm, document evidence coverage, and validate limits and access behavior. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Live demo validation showed schema-only discovery and lost source scope on follow-ups. Explain label-name versus value discovery, Loki selector requirements, and scope preservation in tool descriptions and skill guidance without special-casing site data or prompts. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Generate endpoint, tenant and Secret references from the form while keeping log tools disabled when the URL is empty. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
CI derives module toggles and observability connection paths from chart values so additions cannot silently disappear from the installation builder. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Require source discovery before queries and preserve scope in follow-ups. The live run skipped the optional skill and treated rejected queries as unavailable evidence. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Provide actual label-value evidence in the initial discovery result so source selection does not depend on a second schema-only lookup. Bound fan-out to twenty labels and fifty values per label. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Independent label values do not establish component identity. Return bounded series label sets from Loki so the agent can distinguish components within an application. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Give Prometheus, Alertmanager and Loki separate controls and endpoint fields. Clear unselected endpoints, derive the shared module automatically, and allow Loki tools to register without Prometheus. Verify independent selection and plugin registration. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Remove the remaining metrics prerequisite for standalone Loki installations. Verify Grafana still registers dashboard creation. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Treat dashboard creation as an observation workflow while retaining Edit requirements for infrastructure mutations and generic execution. Restore policy assertions for both dashboard tools. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Use the same existing Secret configuration for both dashboard tool providers so enabling the Grafana module authenticates its tools as well as the observability tools. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Accept and verify datasource references per panel, validate LogQL through Grafana and its UI proxy, and preserve datasource types when saving dashboards. Expose datasource discovery through existing tools and reject failed or empty validation before creation. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Strip the upstream base path before adding the UI proxy prefix, and keep external dashboard URLs free of the proxy prefix. Test both dashboard providers against a Grafana deployment under a subpath. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Apply the repository-required NVIDIA SPDX header to the new behavioral test file. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Provide connection values, an optional authentication Secret, an upgrade command, and a verification prompt. Move query constraints into a reference page and Slurm logging prerequisites into the Slurm guide. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Use one Helm command and a short verification note alongside the observability integrations. Keep optional authentication and tenant setup in the Loki reference. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Resolve the overlapping View-mode dashboard comment using the fuller explanation from main. Preserve dashboard creation access and incorporate the verified UI image pin and policy tests. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Accept labeled vector and matrix results alongside log streams. Add instant evaluation and optional range steps for counts, rates, and aggregations, preserving complete numeric results within existing response limits. Update documentation and agent guidance; verify instant and range queries against live Loki. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Replace tool parameters with natural-language examples in the user guide. Keep numeric query mechanics in the agent skill and remove its stale metric-query exclusion. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Include live datasource names, types, and UIDs in validation responses so missing or incorrect selections can be corrected directly. Preserve datasource discovery on empty dashboard searches and test recovery in both dashboard tool implementations. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Explain datasource identifiers and validation choices, preserve requested panel sources, and distinguish empty time windows from unavailable data. Cover label-based workload metric discovery and include Loki in the Grafana skill description. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFA can query existing Loki logs in View mode without head-node SSH. Adds label discovery and bounded LogQL log queries, optional tenant and Secret-backed Authorization configuration, and guidance to correlate logs with metrics and job accounting. Loki remains disabled unless configured; this does not deploy collectors.