Skip to content

fix(deps): align pandas bounds across dependency sections - #792

Open
kendrickb-nvidia wants to merge 1 commit into
mainfrom
codex/align-pandas-bounds
Open

kendrickb-nvidia wants to merge 1 commit into
mainfrom
codex/align-pandas-bounds

Conversation

@kendrickb-nvidia

@kendrickb-nvidia kendrickb-nvidia commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Require pandas>=2.1.3,<3 in both the base dependencies and engine extra. Remove the redundant pandas constraint from uv configuration and generated constraints.txt, and refresh lockfile metadata without changing resolved package versions.

Human review

  • ⚪ No human review; automated review only
  • 🟡 Partially reviewed or spot-checked by a human
  • 🔵 Complete diff reviewed by a human
  • 🟢 Complete diff reviewed and verified by a human

Pre-Review Checklist

  • mise run format leaves only intended formatting changes.
  • mise run check ::: test passes locally.
  • mise run test:e2e passes locally
  • mise run test:ci-container passes locally (recommended)
  • GPU CI status check passes

Pre-Merge Checklist

  • New or updated tests for any fix or new behavior
  • Updated documentation for new features and behaviors, including docstrings for API docs.

Other Notes

Summary by CodeRabbit

  • Chores
    • The project and engine extra now specify pandas versions below 3.
    • The separate constraints file no longer sets a pandas version limit.

@kendrickb-nvidia
kendrickb-nvidia requested a review from a team as a code owner October 23, 2026 22:40
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⛔ Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock, !uv.lock
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between c06a31b and fbeb76b.

⛔ Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock, !uv.lock

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between bce5b7d and c06a31b.

⛔ Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock, !uv.lock
📒 Files selected for processing: 2
  • constraints.txt
  • pyproject.toml
💤 Files with no reviewable changes: 1
  • constraints.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout: 6
  • GitHub Check: Unit Tests (3.12)
  • GitHub Check: End-user Wheel Install
  • GitHub Check: Unit Tests (3.11)
  • GitHub Check: Unit Tests (3.14)
  • GitHub Check: Unit Tests (3.13)
  • GitHub Check: Greptile Review
🧰 Additional context used
📚 Code guidelines: 2
AGENTS.md — configured
STYLE_GUIDE.md — configured
📓 Path-based instructions: 5
Treat pyproject.toml as high-risk.

⚙️ CodeRabbit configuration file

Files:

  • pyproject.toml
Review as a senior maintainer for NeMo Safe Synthesizer.

⚙️ CodeRabbit configuration file

Files:

  • pyproject.toml
Source excerpt: The CPU/CUDA optional-dependency and `[tool.uv.sources]`/`[[tool.uv.index]]` sections of `pyproject.toml` are generated from `cuda_deps.toml` by `tools/gen_cuda_deps.py` -- never hand-edit the `# >>> BEGIN GENERATED ...

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • pyproject.toml
Applicability reference: AGENTS.md: # AGENTS.md See [STYLE_GUIDE.md](STYLE_GUIDE.md) for detailed code style conventions (Python, markdown, Dockerfiles, shell scripts, testing, config files, docstrings).

📄 CodeRabbit inference engine (STYLE_GUIDE.md)

Files:

  • pyproject.toml
Applicability reference: AGENTS.md: # AGENTS.md See [STYLE_GUIDE.md](STYLE_GUIDE.md) for detailed code style conventions (Python, markdown, Dockerfiles, shell scripts, testing, config files, docstrings).

📄 CodeRabbit inference engine (STYLE_GUIDE.md)

Files:

  • pyproject.toml
🔇 Additional comments: 1
pyproject.toml: 1

29-29: 🗄️ Data Integrity & Integration

The standalone pandas constraint is redundant.

install_nss.sh defaults to the nemo-safe-synthesizer distribution and passes its metadata to uv pip install. The project metadata declares pandas>=2.1.3,<3, so removing the duplicate pandas<3 constraint does not allow pandas 3 through the supported installer path.

Walkthrough

The project dependency now caps pandas below version 3. The engine extra declares the same range. The pandas cap was removed from constraints.txt and constraint-dependencies.

Changes

Pandas version constraints

Layer / File(s) Summary
Pandas dependency declarations
pyproject.toml, constraints.txt
The project dependency specifies pandas>=2.1.3,<3. The engine extra declares the same range. The pandas cap was removed from constraints.txt and constraint-dependencies.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested labels: chore

Suggested reviewers: binaryaaron

Merge Risk: ⚪ Minimal · up to c06a3

The supported installer path retains the pandas version cap through the project dependency. No actionable merge-blocking risk is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: aligning pandas version bounds across dependency sections.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the chore Maintenance not tied to a user-visible change label Oct 23, 2026
@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

This PR puts the pandas bound in the package’s dependency declarations.

  • Base and engine installs agree on the pandas versions they allow.

Reviews (2) · Last reviewed commit: "fix(deps): align pandas bounds across de..." · Reviewed by Greptile

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Signed-off-by: Kendrick Boyd <kendrickb@nvidia.com>
@kendrickb-nvidia
kendrickb-nvidia force-pushed the codex/align-pandas-bounds branch from c06a31b to fbeb76b Compare October 23, 2026 22:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build-dist chore Maintenance not tied to a user-visible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants