fix: expose accurate managed-server readiness - #3197
Merged
ananthsub merged 4 commits intoSep 10, 2026
Merged
Conversation
Signed-off-by: Aditya Uday Malte <aditya.malte@gmail.com>
Signed-off-by: Aditya Uday Malte <aditya.malte@gmail.com>
nemo-automation-bot
Bot
added
the
community-request
ananthsub
requested changes
Sep 9, 2026
ananthsub
left a comment
ananthsub
left a comment
Contributor
There was a problem hiding this comment.
thanks for the contribution! i added 2 comments inline and then this should be good to merge
yaoyu-33
added
area:core
Signed-off-by: Aditya Uday Malte <aditya.malte@gmail.com>
Contributor
|
/ok to test 4f229ac |
ananthsub
approved these changes
Sep 10, 2026
svcnvidia-nemo-ci
removed
the
waiting-on-customer
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
## What does this PR do? - Exposes a /health endpoint alongside the existing root liveness endpoint. - Keeps the managed head server at HTTP 503 while child servers and model endpoints are starting. - Marks the head server ready only after both readiness phases complete, after which /health returns HTTP 200. NeMo Evaluator polls /health before creating its adapter proxy. Without this endpoint, the readiness check receives HTTP 404 and eventually times out. The readiness gate also prevents clients from sending work after child ports are published but before those services are actually ready. ## Testing - 106 tests passed: tests/unit_tests/test_server_utils.py and tests/unit_tests/test_cli.py - Ruff check and format check passed for all changed files - pre-commit run --all-files passed ## Checklist - [x] I have read the contributing guidelines. - [x] The change is focused; no unrelated edits are included. - [x] Tests were added and pass locally. - [x] Pre-commit checks pass locally. - [x] All commits have DCO sign-off. --------- Signed-off-by: Aditya Uday Malte <aditya.malte@gmail.com> Co-authored-by: audaymalte-web <audaymalte@nvidia.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
NeMo Evaluator polls /health before creating its adapter proxy. Without this endpoint, the readiness check receives HTTP 404 and eventually times out. The readiness gate also prevents clients from sending work after child ports are published but before those services are actually ready.
Testing
Checklist