Add Ray Serve gateway for multi-instance vLLM spanning multiple nodes per instance - #3168
Closed
oyilmaz-nvidia wants to merge 9 commits into
Closed
oyilmaz-nvidia wants to merge 9 commits into
oyilmaz-nvidia wants to merge 9 commits into
Conversation
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
prokotg
reviewed
Sep 9, 2026
Comment on lines
+107
to
+112
| return ( | ||
| f"{subject} requires the Ray Serve gateway (use_ray_serve or an instance spanning multiple " | ||
| "nodes), but driver.gym_install is not set. The gateway script " | ||
| "(nemo_gym/orchestration/ray_serve_gateway.py) is fetched from that repo/ref into the vLLM " | ||
| "service's own container - set driver.gym_install.{repo,ref}." | ||
| ) |
Contributor
There was a problem hiding this comment.
That should not be required. Orchestration (including how we route between instances) should be strictly self-contained. I also suppose a case where users will use container without a gym install might be common
Contributor
Author
|
Closing this in favor of this PR #3214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nemo_gym/orchestration/ray_serve_gateway.py) that manages both instance creation and request routing for multi-instance vLLM deployments ingym eval submit, replacing vLLM's own--data-parallel-size/multi-node DP mechanism for topologies it can't express.number_of_instances > 1— each instance now gets its ownvllm serve --distributed-executor-backend rayprocess, explicitly pinned to a distinct slice of nodes via Ray actor node-affinity, so instances can themselves span nodes (e.g. TP8×PP2 across 2 nodes/instance, 2 instances, 4 nodes total).use_ray_serve: truefield onVllmServiceConfigfor topologies that would otherwise work fine with vLLM's own DP.driver.gym_install's repo/ref directly into the vLLM service's own container (git clone+ run as a standalone script — nonemo_gympackage install there, to avoid clobbering vLLM's pinnedtorch/ray), auto-installinggitif the image doesn't bundle it.