cp: fix multimodal image URL SSRF - #761
Open
svcnemo-autobot wants to merge 3 commits into
Open
Conversation
svcnemo-autobot
requested review from
athitten,
meatybobby,
oyilmaz-nvidia and
pthombre
as code owners
September 3, 2026 21:09
Contributor
|
/ok to test e92182c |
nemo-autobot-origin
Bot
force-pushed
the
chore/cherrypick-04d0c4b9-to-r0.7.0
branch
from
September 3, 2026 21:48
e92182c to
e1c9be1
Compare
Contributor
|
/ok to test e1c9be1 |
oyilmaz-nvidia
approved these changes
Sep 4, 2026
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Contributor
|
/ok to test 1e41a87 |
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Contributor
|
/ok to test cbe1b77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Backport the security fix from #741 to the
r0.7.0release branch.What changed
Cherry-picked
04d0c4b9f3945887e4ec26d6859dc988e72c776awith provenance preserved. Restored worker-rank log-prob materialization required by the release branch and aligned stale distributed inference tests with coordinator mode.Details
Adds guarded image URL fetching that rejects non-global addresses, pins validated destinations, and revalidates redirects. Multimodal query and deploy paths use the guarded fetch. Worker ranks now materialize all logits when log probabilities are requested. Obsolete manual-broadcast assertions were replaced with construction-level checks for
materialize_only_last_token_logits=False.Tested
1e41a870: lint and CPU unit tests passed; GPU tests reached 341 passed, 12 skipped, and one stale broadcast assertion failureL0_Unit_Tests_GPUretry stopped before pytest because/tmp/regent-cache/uv/sdists-v9/.gitwas mounted read-onlyCI remains authoritative for
cbe1b77a.