245.pipeline fixes - #248
Conversation
… order to how they run
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage ? 56.65%
=======================================
Files ? 12
Lines ? 826
Branches ? 0
=======================================
Hits ? 468
Misses ? 358
Partials ? 0 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ilaflott
left a comment
There was a problem hiding this comment.
now that i know you keep things in draft mode longer than they should...
There was a problem hiding this comment.
compatible w/ other PR in this repo of yours?
There was a problem hiding this comment.
I think they're separate. This one is going along with a container files update in the fre-cli repo: NOAA-GFDL/fre-cli#915
| echo "WARNING: error with grep execution" | ||
| exit 2 | ||
| fi | ||
| env: |
There was a problem hiding this comment.
help- what's happening here? I haven't encountered the syntax before.
There was a problem hiding this comment.
So to my understanding, this will set the environment variable TASK_NAME as the value given. Then, when run: *task_check runs, it references the environment variable (https://github.com/NOAA-GFDL/fre-workflows/pull/248/changes/BASE..45f3e44c7b15d26a8ba18017de05f3ae7efbb24c#diff-c227019091afe6a400aa5fa75888613791f094da3ca164279ee4551b1708c149R64)
…789/fre-workflows into 245.pipeline-fixes
- I forgot the current directory is being copied basically into itself with changes made
- if certain keys exist, then run the check - maybe just for my own use case --> wanted to see if container updates were causing refinediag and preanalysis failures and if they worked in the rest fo the workflow (if those 2 tasks weren't run)
Describe your changes
Issue ticket number and link (if applicable)
Checklist before requesting a review
Manual Pipeline Run Details
Was the manual pipeline (
test_cloud_runner) triggered for this PR?Result of manual pipeline run:
(Paste relevant logs, output, or a link to the workflow run here)
How to trigger the manual pipeline:
The
test_cloud_runnerpipeline is not automatically associated as a required check with the PR; it must be triggered to test changes in a full post-processing run.To trigger the manual pipeline:
Follow the link to the
test_cloud_runneractions tab hereClick the dropdown "Run workflow":
a. If trying to merge from a branch on fre-workflows: choose branch from the first drop down, leave the next 2 inputs blank, and choose the fre-cli branch to test
b. If trying to merge from a fre-workflows fork: can skip first branch selection, input the fork name (ex: [user]/fre-workflows), input the fork's branch name, and choose the fre-cli branch to test
Click "Run workflow"
Note: you may need to reload the page to see your running workflow.