Skip to content

245.pipeline fixes - #248

Draft
singhd789 wants to merge 41 commits into
NOAA-GFDL:mainfrom
singhd789:245.pipeline-fixes
Draft

245.pipeline fixes#248
singhd789 wants to merge 41 commits into
NOAA-GFDL:mainfrom
singhd789:245.pipeline-fixes

Conversation

@singhd789

Copy link
Copy Markdown
Contributor

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Manual Pipeline Run Details

Was the manual pipeline (test_cloud_runner) triggered for this PR?

  • Yes
  • No

Result of manual pipeline run:

(Paste relevant logs, output, or a link to the workflow run here)

How to trigger the manual pipeline:

The test_cloud_runner pipeline is not automatically associated as a required check with the PR; it must be triggered to test changes in a full post-processing run.

To trigger the manual pipeline:

  1. Follow the link to the test_cloud_runner actions tab here

    • you should see "This workflow has a workflow_dispatch event trigger"
  2. Click the dropdown "Run workflow":

    a. If trying to merge from a branch on fre-workflows: choose branch from the first drop down, leave the next 2 inputs blank, and choose the fre-cli branch to test

    b. If trying to merge from a fre-workflows fork: can skip first branch selection, input the fork name (ex: [user]/fre-workflows), input the fork's branch name, and choose the fre-cli branch to test

  3. Click "Run workflow"

Note: you may need to reload the page to see your running workflow.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@80bca26). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage        ?   56.65%           
=======================================
  Files           ?       12           
  Lines           ?      826           
  Branches        ?        0           
=======================================
  Hits            ?      468           
  Misses          ?      358           
  Partials        ?        0           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80bca26...8861c15. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilaflott ilaflott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that i know you keep things in draft mode longer than they should...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compatible w/ other PR in this repo of yours?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're separate. This one is going along with a container files update in the fre-cli repo: NOAA-GFDL/fre-cli#915

echo "WARNING: error with grep execution"
exit 2
fi
env:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help- what's happening here? I haven't encountered the syntax before.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to my understanding, this will set the environment variable TASK_NAME as the value given. Then, when run: *task_check runs, it references the environment variable (https://github.com/NOAA-GFDL/fre-workflows/pull/248/changes/BASE..45f3e44c7b15d26a8ba18017de05f3ae7efbb24c#diff-c227019091afe6a400aa5fa75888613791f094da3ca164279ee4551b1708c149R64)

@singhd789 singhd789 linked an issue Jul 21, 2026 that may be closed by this pull request
Dana Singh added 14 commits August 3, 2026 12:03
- I forgot the current directory is being copied basically into itself with changes made
- if certain keys exist, then run the check
- maybe just for my own use case --> wanted to see if container updates were causing refinediag and preanalysis failures and if they worked in the rest fo the workflow (if those 2 tasks weren't run)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-organize and update test_cloud_runner

2 participants