Make imetro_behavior modules first-party in sort order - #50
Merged
Merged
Conversation
scastro-nasa
requested review from
crainen-nasa,
eholum-nasa and
ndunkelb-nasa
September 17, 2026 17:18
scastro-nasa
force-pushed
the
scastro/optional-sync-topics
branch
from
September 17, 2026 17:21
b0c2cbc to
5efcc27
Compare
scastro-nasa
force-pushed
the
scastro/first-party-import-sort
branch
from
September 17, 2026 17:21
fb1d713 to
79c393f
Compare
eholum-nasa
approved these changes
Sep 17, 2026
eholum-nasa
left a comment
Member
There was a problem hiding this comment.
🐶
Is there a pre-commit config that would catch this or does pyproject handle it?
Contributor
Author
You can apparently do - id: ruff
args: [
"--line-length=120",
"--fix",
"--ignore=RUF012",
"--config", "lint.isort.known-first-party=['imetro_behavior', 'imetro_behavior_msgs']",
]... is that better? |
Contributor
Author
|
Actually moving both the |
Member
Maybe not worth it... We're a pyproject family now? |
Contributor
Author
scastro-nasa
force-pushed
the
scastro/first-party-import-sort
branch
from
September 17, 2026 19:47
79c393f to
5538a81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I just suggested this to another collaborator, so I gotta put my money where my mouth is.