Skip to content

Make imetro_behavior modules first-party in sort order - #50

Merged
scastro-nasa merged 1 commit into
mainfrom
scastro/first-party-import-sort
Sep 17, 2026
Merged

scastro-nasa merged 1 commit into
mainfrom
scastro/first-party-import-sort

Conversation

@scastro-nasa

Copy link
Copy Markdown
Contributor

I just suggested this to another collaborator, so I gotta put my money where my mouth is.

@eholum-nasa eholum-nasa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶

Is there a pre-commit config that would catch this or does pyproject handle it?

@scastro-nasa

Copy link
Copy Markdown
Contributor Author

Is there a pre-commit config that would catch this or does pyproject handle it?

You can apparently do

-   id: ruff
    args: [
        "--line-length=120",
        "--fix",
        "--ignore=RUF012",
        "--config", "lint.isort.known-first-party=['imetro_behavior', 'imetro_behavior_msgs']",
    ]

... is that better?

@scastro-nasa

scastro-nasa commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor Author

Actually moving both the ruff and ty options to pre-commit-config.yaml looks a little uglier, but it means we can go back to having a pixi.toml again lol -- thoughts?

@eholum-nasa

Copy link
Copy Markdown
Member

Actually moving both the ruff and ty options to pre-commit-config.yaml looks a little uglier, but it means we can go back to having a pixi.toml again lol -- thoughts?

Maybe not worth it... We're a pyproject family now?

@scastro-nasa

Copy link
Copy Markdown
Contributor Author
image

Base automatically changed from scastro/optional-sync-topics to main September 17, 2026 19:46
@scastro-nasa
scastro-nasa force-pushed the scastro/first-party-import-sort branch from 79c393f to 5538a81 Compare September 17, 2026 19:47
@scastro-nasa
scastro-nasa merged commit 985817e into main Sep 17, 2026
2 checks passed
@scastro-nasa
scastro-nasa deleted the scastro/first-party-import-sort branch September 17, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants