fix(mcp): keep stdio child no-proxy entries runtime-safe#2081
Open
hydraxman wants to merge 2 commits into
Open
fix(mcp): keep stdio child no-proxy entries runtime-safe#2081hydraxman wants to merge 2 commits into
hydraxman wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 8edaf4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ffe94e442
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hydraxman
force-pushed
the
fix/stdio-no-proxy-portable-ipv6
branch
from
July 23, 2026 23:10
6ffe94e to
8edaf4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #1931
Problem
When an HTTP proxy is configured, stdio MCP children inherit
[::1]in bothNO_PROXYcasings. Pythonhttpxtreats that entry as an invalid port and exits before the MCP handshake. Removing it unconditionally would instead regress Node's IPv6 loopback bypass whenNODE_USE_ENV_PROXY=1.What changed
[::1]for direct and commonly wrapped Node launchers and JavaScript entry points::1form for other runtimes, while honoring explicit parent or per-server bracketed overridesNo documentation update is needed because the public proxy configuration and precedence are unchanged.
Testing
pnpm exec vitest run test/mcp/client-stdio.test.tsinpackages/agent-core— 29 passedpnpm exec vitest run test/agent/mcp/client-stdio.test.tsinpackages/agent-core-v2— 20 passedpnpm --filter @moonshot-ai/agent-core test— 3,990 passed, 3 expected failures, 30 skipped, 1 todopnpm --filter @moonshot-ai/agent-core-v2 test— 3,958 passedpnpm lint— 0 errors (existing warnings only)httpx.Client()reproducer — bracketed child value fails; portable child value succeeds200 ok; bare value attempts the proxy and failsChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.