fix(acp): surface failed turns to clients#2076
Draft
shizhigu wants to merge 2 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 4bc00f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shizhigu
force-pushed
the
agent/fix-acp-failed-turns
branch
from
July 22, 2026 21:10
9ab5b17 to
cd8b8aa
Compare
shizhigu
marked this pull request as ready for review
July 22, 2026 21:30
shizhigu
marked this pull request as draft
July 22, 2026 22:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #1813
Resolves #1865
Related #2037
Problem
Non-auth
turn.ended(reason: "failed")events resolvedsession/promptwithend_turn. ACP clients treated quota and upstream failures as successful empty turns.What changed
completedend_turncancelledcancelledprovider.filteredrefusalauthRequired (-32000)internalError (-32603)Event failures and prompt rejections now share one mapper. Public Kimi errors expose only
code, canonicalretryable, and an optional valid HTTPstatusCode; provider messages, details, request IDs, and stacks stay off the wire.Prompt settlement also binds to the first new main-agent turn. An older terminal event or a rejected busy prompt cannot settle or overwrite another request.
Validation
git diff --checkpassed.kimi acpsmoke used a local provider returning 403. Two consecutive prompts returned-32603with the allowlisted data; provider text and request ID did not cross the wire.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.