Skip to content

Add dmenu panel movement - #104

Open
Mjoyufull wants to merge 2 commits into
feat/dmenu-panelsfrom
feat/dmenu-panel-movement
Open

Mjoyufull wants to merge 2 commits into
feat/dmenu-panelsfrom
feat/dmenu-panel-movement

Conversation

@Mjoyufull

@Mjoyufull Mjoyufull commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Add opt-in, session-only movement for dmenu panels.

--panel-edit enables Alt+P layout editing: Tab chooses a panel, arrows or mouse dragging dock it, and plus/minus or the wheel resize it. Escape returns to selection without submitting a row. Existing keys are unchanged when disabled; configuration files are never rewritten.

Base: feat/dmenu-panels. Pseudo-terminal and manual panel-editing checks passed.

Greptile Summary

Summary

  • The new persistent dmenu panel-editing setting is not included in the annotated example configuration.
  • The repository requirement to document configuration options and defaults must be satisfied before merging.

Confidence Score: 4/5

Not merge-safe until the required annotated configuration example is added.

One confirmed repository-requirement violation remains.

Files Needing Attention: config.toml

Prompt To Fix All With AI
### Issue 1
src/config/schema.rs:195-196
**Document configuration default**

This adds the persistent `panel_edit` setting with a default of `false`, but the annotated `[dmenu]` example in `config.toml` does not include it. Add `panel_edit = false` with an explanatory comment so users can discover the setting and its default. This violates the repository directive requiring configuration options and defaults in the annotated example, and that requirement must be satisfied before merging.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "Add interactive dmenu panel movement" | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

Context used:

  • Context used - PROJECT_STANDARDS.md (source)

@Mjoyufull
Mjoyufull force-pushed the feat/dmenu-panel-movement branch from 4bea564 to f970418 Compare September 10, 2026 07:23
@Mjoyufull
Mjoyufull marked this pull request as ready for review September 11, 2026 01:18

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f97041872b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/modes/dmenu/movement.rs Outdated
Comment thread src/config/schema.rs

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 11 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/modes/dmenu/movement.rs
Comment thread src/modes/dmenu/movement.rs Outdated
Comment thread src/cli/help.rs Outdated
Comment thread USAGE.md
@Mjoyufull
Mjoyufull force-pushed the feat/dmenu-panel-movement branch from f970418 to 0437eb1 Compare September 13, 2026 03:02
@Mjoyufull
Mjoyufull force-pushed the feat/dmenu-panel-movement branch 2 times, most recently from c90e734 to d45d578 Compare September 16, 2026 10:09
@Mjoyufull
Mjoyufull force-pushed the feat/dmenu-panel-movement branch from d45d578 to 120d024 Compare September 17, 2026 00:32
@Mjoyufull
Mjoyufull force-pushed the feat/dmenu-panel-movement branch 2 times, most recently from bfdf4c9 to 99ce75c Compare September 21, 2026 09:57
@Mjoyufull
Mjoyufull force-pushed the feat/dmenu-panel-movement branch from 99ce75c to 591faee Compare September 22, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant