Conversation
Set SSH_TTY to allocated remote tty; test alongside SSH_AUTH_SOCK etc.
MisterTea
changed the title
MisterTea
marked this pull request as draft
September 20, 2026 16:37
MisterTea
marked this pull request as ready for review
September 22, 2026 16:56
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #825 +/- ##
==========================================
- Coverage 79.88% 79.73% -0.16%
==========================================
Files 152 153 +1
Lines 22144 22268 +124
Branches 14338 14410 +72
==========================================
+ Hits 17690 17755 +65
- Misses 2641 2668 +27
- Partials 1813 1845 +32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Drive setup()/runTerminal() with a custom SHELL so CI fails if the
production setenv("SSH_TTY", ...) is removed (#425).
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
SSH_TTYfrom the allocated pseudo-terminal immediately before starting the remote shell, and leaves it unset when no terminal name is available.The regression test drives
PseudoUserTerminal::setup()intorunTerminal()with a customSHELLthat prints$SSH_TTY, so the check fails if thatsetenvis removed. Confirmed locally: the test fails with thesetenvcommented out and passes with it restored. Full localctestwas 505/505 after merging currentmaster.Closes #425.