Repository navigation
java/apache-commons-httpclient: fix source encoding replacement - #3369
Merged
Merged
Conversation
Run the legacy ISO-8859-1 source substitution in the C locale so sed can replace the non-UTF-8 author name before javac runs. AI-Assisted-by: OpenAI Codex <noreply@openai.com> Signed-off-by: Lucas Holt <luke@foolishgames.com>
Contributor
Reviewer's GuideConfigurationRun the legacy source substitution in the C locale so sed can match and replace the ISO-8859-1 author name before compilation.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Claude finished @laffer1's task in 11s —— View job Review of PR #3369Verdict: LGTM. The change is one line in
Caveats:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the i386 Magus 652 build failure.
The legacy source is ISO-8859-1. Its existing post-patch sed substitution ran under UTF-8, so it could not match and replace the non-UTF-8 author-name byte before javac compiled the source. Run that substitution with
LC_ALL=Cfor byte-wise matching.Validation:
portlint -Cretains an existing PLIST_FILES fatal and pre-existing warnings unrelated to this change.Summary by Sourcery
Bug Fixes: