Repository navigation
sysutils/rsyslog8: Update to 8.2610.0 - #3368
Conversation
Update dependencies and portability patches for the current scheduled-stable release. AI-Assisted-by: Codex (GPT-6) <noreply@openai.com> Signed-off-by: Lucas Holt <luke@foolishgames.com>
Reviewer's GuideImplementationRefresh the OpenSSL portability patch and add the missing unistd.h include, while removing patches no longer needed by the updated upstream source.
ConfigurationUpdate the port version and dependencies, enable GNU make and omkinesis, and include the updated package manifest for the newly enabled modules.
Lock files and vendored codeRefresh the distfile checksums and sizes to match the updated upstream release.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Claude finished @laffer1's task in 23s —— View job Review of PR #3368: sysutils/rsyslog8 8.2502.0 → 8.2610.0I reviewed the diff and the port files. I did not run a build. Findings
Not checked
Verdict: Looks good overall. Fix the doubled-backslash patch context (item 1) and confirm where |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="sysutils/rsyslog8/files/patch-runtime_nsd__ossl.c" line_range="5" />
<code_context>
- dbgprintf("osslPostHandshakeCheck: Debug Shared ciphers = %s\n", szDbg);
+@@ -949,7 +949,7 @@ osslPostHandshakeCheck(nsd_ossl_t *pNsd) {
+ if (SSL_get_shared_ciphers(pNsd->pNetOssl->ssl, szDbg, sizeof szDbg) != NULL)
+ dbgprintf("osslPostHandshakeCheck: Debug Shared ciphers = %s\\n", szDbg);
-- #if OPENSSL_VERSION_NUMBER >= 0x10002000L
</code_context>
<issue_to_address>
**TLS debug lines lose line breaks**
When TLS shared-cipher diagnostics are emitted, `dbgprintf` receives `\\n` in its format string, so it prints the literal characters `\n` instead of ending the line; shared-cipher diagnostics run together with subsequent log output.
Use a single backslash in the C string escape so the diagnostic ends with a newline.
</issue_to_address>| dbgprintf("osslPostHandshakeCheck: Debug Shared ciphers = %s\n", szDbg); | ||
| @@ -949,7 +949,7 @@ osslPostHandshakeCheck(nsd_ossl_t *pNsd) { | ||
| if (SSL_get_shared_ciphers(pNsd->pNetOssl->ssl, szDbg, sizeof szDbg) != NULL) | ||
| dbgprintf("osslPostHandshakeCheck: Debug Shared ciphers = %s\\n", szDbg); |
There was a problem hiding this comment.
⚪ Low · TLS debug lines lose line breaks
When TLS shared-cipher diagnostics are emitted, dbgprintf receives \\n in its format string, so it prints the literal characters \n instead of ending the line; shared-cipher diagnostics run together with subsequent log output.
Use a single backslash in the C string escape so the diagnostic ends with a newline.
Prompt for AI agents
In `sysutils/rsyslog8/files/patch-runtime_nsd__ossl.c` at line 5:
**TLS debug lines lose line breaks**
When TLS shared-cipher diagnostics are emitted, `dbgprintf` receives `\\n` in its format string, so it prints the literal characters `\n` instead of ending the line; shared-cipher diagnostics run together with subsequent log output.
Use a single backslash in the C string escape so the diagnostic ends with a newline.
Update rsyslog from 8.2502.0 to the 8.2610.0 scheduled-stable release. Declare its new YAML and statistics push dependencies, include the newly enabled modules, and refresh portability patches and build tooling.
Validation:
The existing port configuration disables the larger upstream integration testbench.
Summary by Sourcery
Update the rsyslog8 port to the 8.2610.0 release with expanded module support, refreshed dependencies, and portability updates.
New Features:
Enhancements:
Build: