Skip to content

lang/mscript: add VBScript-compatible interpreter - #3367

Merged
laffer1 merged 1 commit into
masterfrom
lang/mscript
Nov 17, 2026
Merged

laffer1 merged 1 commit into
masterfrom
lang/mscript

Conversation

@laffer1

@laffer1 laffer1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Add mscript 0.1, a C++23 interpreter for VBScript-like scripts, and register it in the language category.

Validated on MidnightBSD 4.0.9: makesum, patch, build, fake, package, generated packing list, license check, portlint, and all 20 upstream tests. A staged script smoke test passed.

The upstream v0.1 binary reports version 1.0. MidnightBSD development and earlier 4.0 releases were not tested.

Summary by Sourcery

Add the mscript VBScript-compatible interpreter to the language ports collection.

New Features:

  • Add the mscript VBScript-compatible interpreter as a new language port, including its executable and manual page.

Build:

  • Configure the port to build mscript with C++23 and its required libraries.

Tests:

  • Enable the upstream test target for the new mscript port.

Chores:

  • Register mscript in the language ports category.

Package the 0.1 release and register it in the language category.

AI-Assisted-by: Codex (GPT-6) <noreply@openai.com>
Signed-off-by: Lucas Holt <luke@foolishgames.com>
@sourcery-ai

sourcery-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Sorry @laffer1, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 1 hour and 52 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

sourcery-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Configuration

Add the mscript port with its build, test, install, and package settings, and register it in the language category.

  • lang/Makefile L89
  • lang/mscript/Makefile L1-28

Documentation

Add the package description for mscript.

  • lang/mscript/pkg-descr L1-2

Lock files and vendored code

Record the source archive checksums for the new port.

  • lang/mscript/distinfo L1-3

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Claude finished @laffer1's task in 17s —— View job


Review of lang/mscript (PR #3367)

Verdict: looks good, no blocking issues. I checked the diff statically. I did not build the port, because the environment is Linux and has no MidnightBSD toolchain.

Checked and OK

  • LICENSE=bsd2 is a valid identifier in Mk/components/licenses.db.mk. LICENSE_FILE points at ${WRKSRC}/LICENSE.
  • USES=compiler:c++23-lang is a valid argument in Mk/extensions/compiler.mk.
  • USE_GITHUB with DISTVERSIONPREFIX=v and DISTVERSION=0.1 matches the distfile name laffer1-mscript-v0.1_GH0.tar.gz in distinfo.
  • pkg-descr has no WWW line. WWW is in the Makefile.
  • The lang/Makefile SUBDIR entry is in alphabetical order (after mono6.8, before nawk).
  • .include <bsd.port.mk> matches the other lang ports (e.g. lang/nwcc).
  • MAINTAINER matches the other ports I looked at.
  • There are no patches, and no architecture-specific code is dropped.

Minor notes (non-blocking)

  1. PLIST_FILES lists share/man/man1/mscript.1.gz. This works, but the AGENTS.md workflow is to generate a pkg-plist with bmake makeplist. The inline list is fine for a two-file port, and the PR says the generated packing list was validated.
  2. LDLIBS="${LDFLAGS} -lbsdxml" puts LDFLAGS into LDLIBS. This is unusual. It works only if the upstream Makefile uses LDLIBS in the link line and doesn't also use LDFLAGS. A short comment, or an upstream tweak that honors LDFLAGS and LIBS separately, would make this clearer.
  3. -lbsdxml is in base, so there is no dependency to declare. That is right for 4.0.x, but 3.2 and master were not tested, as the PR says. Confirm that libbsdxml and C++23 compiler support exist on 3.2 if you want to keep that branch supported. If not, consider ONLY_FOR_ARCHS or a version guard.
  4. distinfo has TIMESTAMP = 1794925194. That is a future date relative to now (Nov 2026), probably from a skewed clock on the build host. It is harmless, but bmake makesum on a correctly clocked host would tidy it.
  5. The upstream binary reports version 1.0 while the tag is v0.1. This is only a note, and it doesn't affect the port.

@laffer1
laffer1 merged commit 3c3614d into master Nov 17, 2026
10 checks passed
@laffer1
laffer1 deleted the lang/mscript branch November 17, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant