Skip to content

add uxplay - #3366

Merged
laffer1 merged 1 commit into
masterfrom
x11-toolkits/gtk40-plist
Nov 17, 2026
Merged

laffer1 merged 1 commit into
masterfrom
x11-toolkits/gtk40-plist

Conversation

@laffer1

@laffer1 laffer1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary by Sourcery

Package uxplay 1.73.7 for the multimedia ports collection.

New Features:

  • Add the uxplay AirPlay Unix mirroring server as a multimedia port.

Build:

  • Add the uxplay port to the multimedia ports collection with its build dependencies, packaging metadata, and installation files.

@sourcery-ai

sourcery-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Sorry @laffer1, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 13 hours and 48 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

sourcery-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Configuration

Register uxplay in the multimedia ports category and define its source, dependencies, build options, and installed files.

  • multimedia/Makefile L171
  • multimedia/uxplay/Makefile L1-45

Documentation

Add the package description and installation message for users.

  • multimedia/uxplay/files/pkg-message.in L1-13
  • multimedia/uxplay/pkg-descr L1-13

Lock files and vendored code

Record the source archive checksums for the new port.

  • multimedia/uxplay/distinfo L1-3

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@laffer1
laffer1 merged commit dce86e0 into master Nov 17, 2026
8 of 9 checks passed
@laffer1
laffer1 deleted the x11-toolkits/gtk40-plist branch November 17, 2026 04:45
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Claude finished @laffer1's task in 15s —— View job


Review of PR #3366 (add uxplay)

The PR is already merged. These are post-merge notes from reading the files only. I did not build the port.

Issues

  • multimedia/uxplay/Makefile: PORTDOCS= * is set, but PLIST_FILES lists no docs. If the port installs docs under share/doc/uxplay, they are missing from the plist. If it installs none, PORTDOCS and OPTIONS_DEFINE= DOCS do nothing. Run bmake fake && bmake makeplist to check.
  • multimedia/uxplay/Makefile: .include <bsd.port.mk> is used. Other mports Makefiles may use <bsd.mport.mk>. Confirm this matches the tree's convention.
  • multimedia/uxplay/Makefile: RUN_DEPENDS repeats the libdns_sd.so dependency already in LIB_DEPENDS, so it is redundant.
  • multimedia/uxplay/Makefile: USES contains python and shebangfix for one script, so check python is needed at runtime. If only the shebang matters, USES=python:run or python:3.x+,run would avoid a build dependency. The ssl and gettext-runtime entries also need confirming against what the build actually links.
  • multimedia/uxplay/files/pkg-message.in: avahi's reflect-filters option only takes effect with enable-reflector=yes. The message doesn't say that, so it may mislead users.

Checks that look fine

  • pkg-descr has no WWW line, and WWW is in the Makefile.
  • LICENSE=gpl3 was not checked against Mk/components/licenses.db.mk.
  • The distinfo format is normal.
  • No credentials or unsafe fetch URLs.

Unverified

  • I did not run bmake makesum, bmake fake, bmake package or portlint.
  • I did not confirm that the gstreamer and gnome USES arguments are valid on stable/4.0 and master.
  • I did not check the multimedia/Makefile SUBDIR entry for alphabetical order.

Verdict: Mostly fine. Fix the PORTDOCS mismatch and verify the plist with a staged build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant