Repository navigation
x11-toolkits/gtk40: remove unguarded duplicate plist entries - #3365
Merged
Merged
Conversation
pkg-plist listed the broadway headers both with and without the %%BROADWAY%% guard. BROADWAY is off by default, so fake failed on Magus run 652 (i386, 4.1) with five "not installed" broadway headers. The gdk/x11 headers were likewise duplicated without the %%X11%% guard, which would break builds with X11 disabled and caused duplicate-entry warnings at package time. Default-option package contents are unchanged, so no PORTREVISION bump. AI-Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lucas Holt <luke@foolishgames.com>
Contributor
Contributor
Reviewer's GuideConfigurationRemove unguarded duplicate Broadway and X11 header entries from the package plist so files are required only when their options are enabled.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Claude finished @laffer1's task in 15s —— View job Review of #3365: gtk40 plist cleanupVerdict: looks good to merge.
Findings
Not verified
No changes were pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the gtk40 4.24.0_1 failure on Magus run 652 (i386, 4.1, port_id 2304857):
pkg-plistlisted the broadway headers both with and without the%%BROADWAY%%guard. BROADWAY is off by default, so the unguarded copies are never installed.The 16
gdk/x11/*.hheaders were also duplicated without the%%X11%%guard. They produced duplicate-entry warnings at package time and would breakWITHOUT=X11builds. This PR removes those copies too.Default-option package contents are unchanged, so there is no PORTREVISION bump.
Testing
bmake fake package WITHOUT="BROADWAY GSTREAMER"on amd64 passed and producedgtk4-4.24.0_1.mport. GSTREAMER was off only because the build host has an older gstreamer1-plugins-bad installed. Its plist entries are separately guarded.PLIST_SUBand compared it to the fake tree: 628 entries, 0 missing, no duplicates.git diff --checkis clean. portlint reports 0 fatal errors.🤖 Generated with Claude Code
Summary by Sourcery
Bug Fixes: