Skip to content

comp-swapchain-examples: Correct simple variable use in for loop - #1886

Merged
John Kennedy (GrantMeStrength) merged 1 commit into
MicrosoftDocs:docsfrom
MarijnS95:patch-1
Aug 27, 2026
Merged

comp-swapchain-examples: Correct simple variable use in for loop#1886
John Kennedy (GrantMeStrength) merged 1 commit into
MicrosoftDocs:docsfrom
MarijnS95:patch-1

Conversation

@MarijnS95

@MarijnS95 Marijn Suijten (MarijnS95) commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

The commented line sets up a specific constant of 50 in a variable numPresents, but then goes ahead and repeats the same constant 50 again instead of using numPresents.

@prmerger-automator

prmerger-automator Bot commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

Marijn Suijten (@MarijnS95) : Thanks for your contribution! The author(s) have been notified to review your proposed change.

GrantMeStrength
John Kennedy (GrantMeStrength) approved these changes Jul 17, 2026
View reviewed changes

@GrantMeStrength John Kennedy (GrantMeStrength) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — accurate improvement. Approved.

@MarijnS95

Marijn Suijten (MarijnS95) commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Such a coincidence - open for 2 years, I looked at it yesterday and assumed I might need to rebase it or it would go unnoticed 😁

@GrantMeStrength

John Kennedy (GrantMeStrength) commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Copilot /review

GrantMeStrength
John Kennedy (GrantMeStrength) approved these changes Jul 17, 2026
View reviewed changes

@GrantMeStrength John Kennedy (GrantMeStrength) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed ✅ — Documentation improvement looks good.

@prmerger-automator

prmerger-automator Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Marijn Suijten (@MarijnS95) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. Jim Walker (@jwmsft)

1 similar comment
@prmerger-automator

prmerger-automator Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Marijn Suijten (@MarijnS95) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. Jim Walker (@jwmsft)

@GrantMeStrength
John Kennedy (GrantMeStrength) merged commit ae532ee into MicrosoftDocs:docs Aug 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrantMeStrength John Kennedy (GrantMeStrength) GrantMeStrength approved these changes
@jwmsft Jim Walker (jwmsft) Awaiting requested review from jwmsft

Assignees

@GrantMeStrength John Kennedy (GrantMeStrength)

Labels

Change sent to author desktop-app-ui/subsvc do-not-merge needs-human-review windows-api-desktop-tech/svc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarijnS95 @GrantMeStrength @jwmsft