Add configurable Workshop dependency manifests#115
Closed
ilker2445 wants to merge 8 commits into
Closed
Conversation
Cynosphere
reviewed
Jun 14, 2026
|
|
||
| function RefreshDependencies() | ||
| local players = {} | ||
| for _, pl in next, player.GetAll() do |
Member
There was a problem hiding this comment.
Suggested change
| for _, pl in next, player.GetAll() do | |
| for _, pl in player.Iterator() do |
Author
|
Superseded by #116, which contains the cleaned-up, fully validated final branch as a single commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The preliminary dependency mounting path recursively mounted every declared Workshop child. That gave users no opportunity to reject irrelevant dependencies, and it provided no separate aggregate size policy for dependency content.
This change makes dependency mounting opt-in and explicit. The wearer chooses which declared dependencies belong with the outfit, while every receiving client keeps control through its own dependency mounting setting and size limit.
Behavior
outfitter_mount_children_testconvaroutfitter_dependency_maxsizedefaults to 60 MB and limits the combined selected dependency sizeAlready-mounted Workshop items cannot be unmounted until Garry's Mod restarts; the review dialog mentions this limitation.
Validation
git diff --checkpassesdevhead and is 0 commits behindThis has not yet received live in-game testing.