Repository navigation
docs(mmq): the test cases' comments, against #29953's head - #457
Merged
Merged
Conversation
Comment-only change to tasks/mmq-tests.patch: the cases are unchanged, which a comment-stripped comparison of tests/test-backend-ops.cpp before and after shows (identical, 496,625 bytes; a one-character code change is caught). Three comments were wrong: - dense321: dd266785c's get_J_max(321) is 128, not 80. The launch picks J = 80 only because J = 96..128 exceed sm_75's 64 KiB of shared memory, a filter get_J_max() does not apply -- which is why master passed this case and the published #29953, padding exactly 80 blocks, faulted. - ids16/ids64 said every rule gives src1 enough room, so only ids_dst can be read past. ids16 is where src1 is short (21 blocks needed, 16 given), and get_J_max(ne11) = get_J_max(ne12) = J does not hold for ids64 (64, 96, 112). - The MUL_MAT_ID header said the padding must cover the widest tile the launch can pick: the fork's 903 rule, not what #29953's head does. The rest now describes each case against the head, names dd266785c where it means master's old get_J_max(), and says the cases fault only with an allocation that ends at its data. The harness marker 'get_J_max(113) = 64' is kept, and the patch still applies to dd266785c and to 3070d927f. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comment-only fix to
docs/maxusai/tasks/mmq-tests.patch, thetest-backend-opscases behind the llama.cpp#29953 work. The cases are unchanged. Three comments were wrong, and the rest described the rules from before #29953.dense321said master'sget_J_max(321) = 80. It is 128: the launch picksJ = 80only becauseJ = 96..128need more than sm_75's 64 KiB of shared memory, a filterget_J_max()does not apply. That is why master passed this case and the published #29953, padding exactly 80 blocks, faulted. Computed on the CPU fromdd266785c's config tables.ids16/ids64said every rule gives src1 enough room, so onlyids_dstcan be read past.ids16is the case where src1 is short, 21 blocks needed against 16 given, andget_J_max(ne11) = get_J_max(ne12) = Jdoes not hold forids64(64, 96 andJ = 112).Every comment now describes its case against #29953's head (
3070d927f), namesdd266785cwhere it means master's oldget_J_max(), and says the cases fault only with an allocation that ends at its data.Test plan
tests/test-backend-ops.cppwith the old and with the new patch applied, comments stripped (cpp -fpreprocessed), is byte-identical (496,625 bytes), and the same comparison catches a one-character change to a test case.dd266785cand to3070d927f, and the harness markerget_J_max(113) = 64is still found after applying it.check_source_paths.py; name scan.🤖 Generated with Claude Code
From
ai-server/mlx-cudavia /collab · 2026-10-05 · buildllama.cpp dd266785c / 3070d927f· signedai-server