fix(geometry): recompute DashedLine dashes on put_start_and_end_on#4885
Closed
Chessing234 wants to merge 2 commits into
Closed
fix(geometry): recompute DashedLine dashes on put_start_and_end_on#4885Chessing234 wants to merge 2 commits into
Chessing234 wants to merge 2 commits into
Conversation
Rebuild dash submobjects when endpoints change so dash length stays consistent instead of stretching existing segments. Fixes ManimCommunity#3989 Co-authored-by: Cursor <cursoragent@cursor.com>
Delegate to Line when endpoints coincide; only rebuild dashes for non-degenerate length changes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DashedLinecomputed dash count only at init;put_start_and_end_onleft stale dashes ([BUG] DashedLine computes num_dashes only once (on init) #3989).Fixes #3989
Test plan
pytest tests/module/mobject/types/vectorized_mobject/test_dashed_vmobject.py -o addopts=\"\"Made with Cursor