fix(creation): suspend starting_mobject updaters in ShowPartial#4884
Closed
Chessing234 wants to merge 4 commits into
Closed
fix(creation): suspend starting_mobject updaters in ShowPartial#4884Chessing234 wants to merge 4 commits into
Chessing234 wants to merge 4 commits into
Conversation
ShowPartial rebuilds each frame from starting_mobject; suspend its updaters too when suspend_mobject_updating is set. Fixes ManimCommunity#4763 Co-authored-by: Cursor <cursoragent@cursor.com>
Default Create now suspends starting_mobject updaters (ManimCommunity#4763). Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid coupling the graphical test to Create's starting_mobject behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Createrebuilds fromstarting_mobjecteach frame; its updaters kept running and leaked into the result whensuspend_mobject_updating=True(Create() does not suspend Mobject updating #4763).starting_mobjectinShowPartial.begin().GrowFromCenterin the graphical updater test that was relying on the old behavior.Fixes #4763
Test plan
pytest tests/module/animation/test_creation.py -o addopts=\"\"pytest tests/test_graphical_units/test_updaters.py::test_UpdateSceneDuringAnimation -o addopts=\"\"Made with Cursor