feat:add Kwin controller init - #43
Open
lava114514 wants to merge 3 commits into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体性的反馈：
NewKWinController的文档注释和函数之间隔着一个空行和额外注释；在 Go 中，导出的函数注释应该紧贴在对应的func声明上一行（例如，可以把参数说明合并进主文档注释，或者把参数说明移到函数下面）。- 建议将
NewKWinController构造函数的报错信息和行为与现有的控制器构造函数（例如NewWlRootsController）对齐，这样在控制器创建失败时，调用方能看到一致的错误文案和语义。
给 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- The doc comment for `NewKWinController` is separated from the function by a blank line and additional comments; in Go the exported function comment should be directly above the `func` line (e.g., collapse the parameter notes into the main doc comment or move them below the function).
- Consider aligning the `NewKWinController` constructor’s error message and behaviour with the existing controller constructors (e.g., `NewWlRootsController`) so callers see consistent error text and semantics when controller creation fails.帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进后续的代码审查。
Original comment in English
Hey - I've left some high level feedback:
- The doc comment for
NewKWinControlleris separated from the function by a blank line and additional comments; in Go the exported function comment should be directly above thefuncline (e.g., collapse the parameter notes into the main doc comment or move them below the function). - Consider aligning the
NewKWinControllerconstructor’s error message and behaviour with the existing controller constructors (e.g.,NewWlRootsController) so callers see consistent error text and semantics when controller creation fails.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The doc comment for `NewKWinController` is separated from the function by a blank line and additional comments; in Go the exported function comment should be directly above the `func` line (e.g., collapse the parameter notes into the main doc comment or move them below the function).
- Consider aligning the `NewKWinController` constructor’s error message and behaviour with the existing controller constructors (e.g., `NewWlRootsController`) so callers see consistent error text and semantics when controller creation fails.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
函数签名对不上喔 |
lava114514
marked this pull request as draft
July 15, 2026 09:17
Member
|
Interception那个可以不用理会 |
lava114514
marked this pull request as ready for review
July 16, 2026 15:22
Contributor
There was a problem hiding this comment.
Hey - 我已经审查了你的更改，看起来很棒！
帮我变得更有用！请在每条评论上点击 👍 或 👎，我会根据这些反馈来改进为你提供的审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
但我挺好奇的，为什么kwin这边就没有用固定宽度类型，这对ffi好像不太合适吧。 @MistEO 看看 |
Member
Contributor
|
@dongwlin 先暂时别合了，我在合并两个 Linux 控制器 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加kwin控制器相关
由 Sourcery 提供的摘要
为兼容 KWin 的 Wayland 环境添加一个新的控制器实现，并通过框架绑定暴露其原生构造函数。
新功能：
NewKWinController，用于在支持 XDG Screencast Portal 和uinput的 Wayland 组合器上创建控制器。改进：
MaaKWinControllerCreate，并将其注册到框架入口列表中。Original summary in English
Summary by Sourcery
Add a new controller implementation for KWin-compatible Wayland environments and expose its native constructor through the framework bindings.
New Features:
Enhancements:
新功能：
NewKWinController构造函数，用于创建面向 KWin Wayland 环境的控制器。增强：
MaaKWinControllerCreate，并将其注册到框架入口列表中。Original summary in English
由 Sourcery 提供的摘要
为兼容 KWin 的 Wayland 环境添加一个新的控制器实现，并通过框架绑定暴露其原生构造函数。
新功能：
NewKWinController，用于在支持 XDG Screencast Portal 和uinput的 Wayland 组合器上创建控制器。改进：
MaaKWinControllerCreate，并将其注册到框架入口列表中。Original summary in English
Summary by Sourcery
Add a new controller implementation for KWin-compatible Wayland environments and expose its native constructor through the framework bindings.
New Features:
Enhancements: