Repository navigation
test(vault): fix the default JWT exp once so equal tokens compare equal (flaky CI) - #526
Merged
Merged
Conversation
jwt() took exp from time.time() on every call, so a test comparing a stored credential with an expected one built a moment later failed whenever a clock second ticked between the two calls. It flaked CI on PR #523 (TestProjectPicker::test_select_fills_the_existing_credential). Forcing a one-second tick between two calls: old helper -> tokens differ, new -> identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MCERQUA
enabled auto-merge (squash)
October 4, 2026 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
jwt()test helper intests/test_vault_connectors.pytookexpfromtime.time()on every call. Tests that compare a stored credential against an expected one built a moment later failed whenever a clock second ticked between the two calls. It flaked CI on #523:TestProjectPicker::test_select_fills_the_existing_credential, which passes 3/3 locally on the same commit.The default expiry is now computed once at import. Explicit
exp=arguments are unchanged.Shown both ways by forcing a one-second tick between two
jwt()calls: old helper -> tokens differ; new helper -> identical.tests/test_vault_connectors.py: 83 passed, 1 skipped. Test-only change.