Repository navigation
Conversation
|
Thanks for opening a PR! A few things that help this get reviewed:
PRs that clearly don't follow these likely won't get reviewed in a reasonable timeframe. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #914
The exported plan contains "GTP 32b UK", but the shared workout cards can visually lose the "UK" suffix. The name passes unchanged to
SessionSummaryTitle. Its title container was allowed to clip overflow and kept children aligned to their intrinsic widths.This removes the clipping and lets the title stretch/wrap within the available card width. No data model or navigation changes.
Checks: A targeted component regression test passes, and fails against unchanged 4.24.1 code. Formatting passes.
Pending: Verify the actual layout with the reported plan on an ARM Android device and attach before/after screenshots. The official APK is ARM-only and could not run on our x86_64 test emulator; therefore opening as draft for now.