Repository navigation
fix(release): strip every comment from changelog entries and notes - #25
Merged
Merged
Conversation
cleanEntry and draftNotes removed guidance comments in one pass, so a comment split around another (`<!<!-- x -->-- y -->`) left a whole `<!-- y -->` behind in the release notes. They now repeat until no comment is left. CodeQL flagged both as incomplete multi-character sanitization on the release pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Review and fix — pass 1No new findings. Checked by 1 finder (correctness, tests) · architecture review · nothing to score. Ready to merge, as far as this review can see. Nothing is open from this pass or any pass before it. |
THPubs
added a commit
that referenced
this pull request
Oct 20, 2026
Add #25 to the 0.13.0 entry. It merged into dev after the release commit, so the release check on main refused to build until the entry lists it. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cleanEntryanddraftNotesinscripts/release-lib.mjsnow strip HTML comments until none is left, through a smallstripCommentshelper, instead of in a single pass.Why
CodeQL flagged both on the release pull request (#24) as incomplete multi-character sanitization. A single pass of
/<!--[\s\S]*?-->/gover<!<!-- x -->-- y -->leaves a whole<!-- y -->, which would reach the release notes andlatest.json. The input is our own commit titles and changelog, so the risk is low, but the fix is small.How I tested it
<!-- y -->.pnpm checkpasses.Checklist
dev.pnpm checkpasses.🤖 Generated with Claude Code