Feat workdir + bugfix - #96
Merged
Merged
Conversation
feat: add landlock glob pattern
…ove logging. Also manage run0.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #96 +/- ##
==========================================
- Coverage 71.91% 68.66% -3.25%
==========================================
Files 45 50 +5
Lines 5903 6240 +337
==========================================
+ Hits 4245 4285 +40
- Misses 1658 1955 +297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Verifying is_self_terminating, Verifying PTY in terminal Adding signal mask roundtrip
This might debloat a bit the binary, cost a bit in performance, but it's way more maintainable now.
…d many more. tldr; https://www.reddit.com/r/rust/comments/1ttj8am/comment/op2viog/ 38 files changed, 5301 insertions(+), 2494 deletions(-) lgtm
Owner
Author
|
Well, LGTM now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a massive PR, containing huge bugfixes based on a better understanding of
sudo-rsexec implementation.Then, I implemented the workdir feature in addition to splitting deserialisation to specific modules in sr folder.
This is a preparation for more incoming optimizations, because, we can go BEYOND!
I also merged main branch edits.
We are near to release.