Skip to content

fix(identity): pass sign-in scopes as typed arguments - #725

Merged
Knucklessg1 merged 1 commit into
mainfrom
fix/signin-scope-typing
Nov 17, 2026
Merged

Knucklessg1 merged 1 commit into
mainfrom
fix/signin-scope-typing

Conversation

@Knucklessg1

Copy link
Copy Markdown
Member

What

RemoteAuthProvider received the native sign-in scopes through a **dict unpack. The type checker cannot match a dict[str, list[str]] unpack to the provider's keyword parameters, so the locked-environment type check on main failed with six arg-type errors in server_factory.py.

Both call sites now pass scopes_supported= and challenge_scopes= explicitly, from a helper that returns the scope list.

Impact

None at runtime: the protected-resource metadata and the 401 challenge advertise the same scopes as before (ARBORA-IDENTITY-R030.4.8).

Verification

  • mypy on server_factory.py: no issues.
  • tests/identity/test_native_signin_scopes.py: 5 passed.

🤖 Generated with Claude Code

The sign-in scopes reached RemoteAuthProvider through a dict unpack, which the
type checker cannot match to the keyword parameters, so main's locked type check
failed. The scopes are now passed as scopes_supported and challenge_scopes
directly; what the server advertises is unchanged.

Spec: ARBORA-IDENTITY-R030.4.8
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Knucklessg1
Knucklessg1 merged commit fa383f3 into main Nov 17, 2026
6 checks passed
@Knucklessg1
Knucklessg1 deleted the fix/signin-scope-typing branch November 17, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant